Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Added support for function deployment from gzip/bzip2/xz compressed tar files #1168

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

varunbpatil
Copy link
Contributor

Issue Ref: #1167

Description:
Added support for deploying and updating functions from gzip/bzip2/xz compressed tar files.
Supports the following standard file extensions - .tar.gz, .taz, .tgz, .tar.bz2, .tb2, .tbz, .tbz2, .tz2, .tar.xz

TODOs:

  • Ready to review
  • Automated Tests
  • Docs

@varunbpatil varunbpatil changed the title Added support for gzip/bzip2/xz compressed tar files Added support for function deployment gzip/bzip2/xz compressed tar files Sep 7, 2020
@varunbpatil varunbpatil changed the title Added support for function deployment gzip/bzip2/xz compressed tar files Added support for function deployment from gzip/bzip2/xz compressed tar files Sep 7, 2020
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @varunbpatil, nice test coverage :) For the changes in the unzip image to take effect, you need to update the image reference in the manifest (kubeless-non-rbac.jsonnet). I have built the image with your changes, replace it to be able to run your tests: kubeless/unzip@sha256:e867f9b366ffb1a25f14baf83438db426ced4f7add56137b7300d32507229b5a)

@varunbpatil
Copy link
Contributor Author

varunbpatil commented Sep 7, 2020

Thanks @andresmgot :) In order to run the url+compressedtar tests from examples/Makefile, I also need the compressed tar's to be present in the examples folder already. Do you want me to create a separate PR for just those 3 files?

Edit: I have parameterized the URLs in examples/Makefile to use the commit SHA1 from Circle CI so that we can refer to files created in the current PR instead of the files from master branch. I have also fixed the prevailing CI failure in get-python-metadata. CI is passing with these changes.

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the changes!

@andresmgot andresmgot merged commit b87adf8 into vmware-archive:master Sep 8, 2020
@varunbpatil varunbpatil deleted the compressed-tar branch September 15, 2020 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants