Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Add support for containerd-based images #79

Open
detiber opened this issue Aug 22, 2018 · 6 comments
Open

Add support for containerd-based images #79

detiber opened this issue Aug 22, 2018 · 6 comments

Comments

@detiber
Copy link
Contributor

detiber commented Aug 22, 2018

Currently wardroom bakes images that use docker, we should add the ability to generate images that use containerd instead.

@vincepri
Copy link
Contributor

vincepri commented Aug 29, 2018

This is being worked on here kubernetes-sigs/cluster-api-provider-aws#25 and can be ported here after testing.

@scottslowe
Copy link
Contributor

I know that @vincepri said there's some work happening in cluster-api, but I have a branch I can submit as a PR (based on Vince's work) if we'd like to go ahead and close this out.

@detiber
Copy link
Contributor Author

detiber commented Sep 21, 2018

@scottslowe that would be great, we just haven't had the time to verify the containerd changes do not break the swizzle workflows yet :)

@scottslowe
Copy link
Contributor

@detiber I haven't tested the swizzle workflows, either. I think @craigtracey may have some changes for the swizzle workflows that he has yet to check in. I'll check with him on the status of those changes so that we can see if we should test now or wait for his changes.

@stevesloka
Copy link
Contributor

Why do we have the same code in multiple repos and copy/paste between them? Can't we standardize on Wardroom?

@detiber
Copy link
Contributor Author

detiber commented Sep 21, 2018

@stevesloka long term we'd like to standardize the image baking and contribute upstream. Currently we contributed that for cluster-api-provider-aws, but the plan is to try and make it more generally available for the cluster-api.

The main issue with standardizing on Wardroom has been that the scope of this repo has grown beyond just image baking and testing/validating that changes do not break the existing workflows for those additional uses is difficult (such as these containerd changes, which impact the swizzle workflows).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants