Merge pull request #579 from rguske/issue-573

Fix the error stopping behaviour for kn-pcli-tag function

examples/knative/powercli/kn-pcli-tag/handler.ps1

@@ -1,4 +1,6 @@
 Function Process-Init {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Init`n"
 
    try {
@@ -17,23 +19,31 @@ Function Process-Init {
    [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor [System.Net.SecurityProtocolType]::Tls12 -bor [System.Net.SecurityProtocolType]::Tls13
 
    Write-Host "$(Get-Date) - Configuring PowerCLI Configuration Settings`n"
-   Set-PowerCLIConfiguration -InvalidCertificateAction:${VCENTER_CERTIFICATE_ACTION} -ParticipateInCeip:$true -Confirm:$false | Out-Null
+   Set-PowerCLIConfiguration -InvalidCertificateAction:${VCENTER_CERTIFICATE_ACTION} -ParticipateInCeip:$true -Confirm:$false
 
    Write-Host "$(Get-Date) - Connecting to vCenter Server $VCENTER_SERVER`n"
-   Connect-VIServer -Server $VCENTER_SERVER -User $VCENTER_USERNAME -Password $VCENTER_PASSWORD | Out-Null
+
+   try {
+      Connect-VIServer -Server $VCENTER_SERVER -User $VCENTER_USERNAME -Password $VCENTER_PASSWORD
+   } catch {
+      Write-Error "$(Get-Date) - Failed to connect to vCenter Server"
+      throw $_
+   }
 
    Write-Host "$(Get-Date) - Successfully connected to $VCENTER_SERVER`n"
 
    Write-Host "$(Get-Date) - Init Processing Completed`n"
 }
 
 Function Process-Shutdown {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Shutdown`n"
 
    Write-Host "$(Get-Date) - Disconnecting from vCenter Server`n"
 
    try {
-      Disconnect-VIServer * -Confirm:$false | Out-Null
+      Disconnect-VIServer * -Confirm:$false
    } catch {
       Write-Error "$(Get-Date) - Failed to Disconnect from vCenter Server"
    }
@@ -42,6 +52,7 @@ Function Process-Shutdown {
 }
 
 Function Process-Handler {
+   [CmdletBinding()]
    param(
       [Parameter(Position=0,Mandatory=$true)][CloudNative.CloudEvents.CloudEvent]$CloudEvent
    )

examples/knative/powershell/kn-ps-echo/handler.ps1

@@ -1,16 +1,21 @@
 Function Process-Init {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Init`n"
 
    Write-Host "$(Get-Date) - Init Processing Completed`n"
 }
 
 Function Process-Shutdown {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Shutdown`n"
 
    Write-Host "$(Get-Date) - Shutdown Processing Completed`n"
 }
 
 Function Process-Handler {
+   [CmdletBinding()]
    param(
       [Parameter(Position=0,Mandatory=$true)][CloudNative.CloudEvents.CloudEvent]$CloudEvent
    )

examples/knative/powershell/kn-ps-email/handler.ps1

@@ -1,16 +1,21 @@
 Function Process-Init {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Init`n"
 
    Write-Host "$(Get-Date) - Init Processing Completed`n"
 }
 
 Function Process-Shutdown {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Shutdown`n"
 
    Write-Host "$(Get-Date) - Shutdown Processing Completed`n"
 }
 
 Function Process-Handler {
+   [CmdletBinding()]
    param(
       [Parameter(Position=0,Mandatory=$true)][CloudNative.CloudEvents.CloudEvent]$CloudEvent
    )

examples/knative/powershell/kn-ps-slack-vsphere-alarm/handler.ps1

@@ -1,16 +1,21 @@
 Function Process-Init {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Init`n"
 
    Write-Host "$(Get-Date) - Init Processing Completed`n"
 }
 
 Function Process-Shutdown {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Shutdown`n"
 
    Write-Host "$(Get-Date) - Shutdown Processing Completed`n"
 }
 
 Function Process-Handler {
+   [CmdletBinding()]
    param(
       [Parameter(Position=0,Mandatory=$true)][CloudNative.CloudEvents.CloudEvent]$CloudEvent
    )

examples/knative/powershell/kn-ps-slack/handler.ps1

@@ -1,16 +1,21 @@
 Function Process-Init {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Init`n"
 
    Write-Host "$(Get-Date) - Init Processing Completed`n"
 }
 
 Function Process-Shutdown {
+   [CmdletBinding()]
+   param()
    Write-Host "$(Get-Date) - Processing Shutdown`n"
 
    Write-Host "$(Get-Date) - Shutdown Processing Completed`n"
 }
 
 Function Process-Handler {
+   [CmdletBinding()]
    param(
       [Parameter(Position=0,Mandatory=$true)][CloudNative.CloudEvents.CloudEvent]$CloudEvent
    )

examples/knative/templates/server.ps1

@@ -84,7 +84,7 @@ $backgroundServer = Start-ThreadJob {
 
                         # Runs Shutdown function (defined in handler.ps1) to clean up connections from warm startup
                         try {
-                            Process-Shutdown
+                            Process-Shutdown -ErrorAction 'Stop'
                         }
                         catch {
                             Write-Error "`n$(Get-Date) - Shutdown Processing Error: $($_.Exception.ToString())"
@@ -98,7 +98,7 @@ $backgroundServer = Start-ThreadJob {
 
                     if ( $cloudEvent -ne $null ) {
                         try {
-                            Process-Handler -CloudEvent $cloudEvent | Out-Null
+                            Process-Handler -CloudEvent $cloudEvent -ErrorAction 'Stop'
                             $context.Response.StatusCode = [int]([System.Net.HttpStatusCode]::OK)
                         }
                         catch {
@@ -136,7 +136,7 @@ $backgroundServer = Start-ThreadJob {
 
     # Runs Init function (defined in handler.ps1) which can be used to enable warm startup
     try {
-        Process-Init
+        Process-Init -ErrorAction 'Stop'
     }
     catch {
         Write-Error "$(Get-Date) - Init Processing Error: $($_.Exception.ToString())"
@@ -155,8 +155,8 @@ $killEvent = new-object 'System.Threading.AutoResetEvent' -ArgumentList $false
 
 Start-ThreadJob {
     param($killEvent, $url, $serverStopMessage)
-    $killEvent.WaitOne() | Out-Null
-    Invoke-WebRequest -Uri $url -Body $serverStopMessage | Out-Null
+    $killEvent.WaitOne()
+    Invoke-WebRequest -Uri $url -Body $serverStopMessage
 } -ArgumentList $killEvent, $localUrl, $serverStopMessage
 
 try {
@@ -171,7 +171,7 @@ try {
 }
 finally {
     Write-Host "$(Get-Date) - PowerShell HTTP Server stop requested. Waiting for server to stop"
-    $killEvent.Set() | Out-Null
+    $killEvent.Set()
     Get-Job | Wait-Job | Receive-Job
     Write-Host "$(Get-Date) - PowerShell HTTP server is stopped"
-}
+}