Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dupe "Processor" entries in /etc/veba-release #633

Closed
lamw opened this issue Sep 30, 2021 · 0 comments
Closed

[BUG] Dupe "Processor" entries in /etc/veba-release #633

lamw opened this issue Sep 30, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@lamw
Copy link
Contributor

lamw commented Sep 30, 2021

Describe the bug
Due to multiple processors being supported, it looks like this code can potentially add multiple Processor entries into /etc/veba-release

# cat /etc/veba-release
Version: release-0.7.0
Commit: c9890cf
Processor: Knative
Processor: Knative

To Reproduce
Deploy VEBA appliance with Webhook and/or Horizon

Expected behavior
Single Processor entry should exists

Screenshots
If applicable, add screenshots to help explain your problem.

Version (please complete the following information):

  • VEBA Form Factor: Appliance
  • VEBA Version: release-v0.7.0

Additional context

Potential fix:

grep -q "Processor" /etc/veba-release || echo "...."
@lamw lamw added the bug Something isn't working label Sep 30, 2021
@lamw lamw added this to the v0.7 Release milestone Sep 30, 2021
lamw pushed a commit to lamw/vcenter-event-broker-appliance that referenced this issue Sep 30, 2021
Closes: vmware-samples#633
Signed-off-by: William Lam <wlam@vmware.com>
@lamw lamw closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant