Add Pagerduty trigger example in go #201

codegold79 · 2020-09-16T23:02:58Z

Summary

This PR adds a Go version of the PagerDuty trigger. Currently, there exists a version in Python.

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

Please ensure that you are making a pull request against the Development branch
Please use the WIP keyword in the title of your PR if you are not ready for review
Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
Please ensure that you have signed all commits and that you have squashed all relevant commmits related to your change
Please make sure that you have tested your change locally by successfully building and deploying the VMware Event Broker Appliance and/or building and deploying VMware Event Router
Please include any relevant screenshots and/or output as part of your testing
Please include any documentation updates that is applicable for your changes

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Please check the type of change your PR introduces:

Bugfix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Code style update (formatting, renaming)
Refactoring (no functional changes, no api changes)
Build related changes
Documentation changes
Other (please describe):

Resolved Issues

List of Issues closed or resolved by this PR. Add multiple Closes keyword followed by the issue number (e.g. Closes #ISSUE-NUMBER)

Closes #ISSUE-NUMBER

Testing Verification

Short summary of testing (e.g. successfully built and deployed VMware Event Broker Appliance)
Please include any relevant screenshots and/or output as part of the testing

Additional Information

Any other details you wish to include or mention

If you have any questions/comments, feel free to reach out to team on Slack #vcenter-event-broker-appliance

Thank you from the VEBA Team! 🥳

martindekov

Looks good Frankie, I will approve just in case and you can refer the comments afterwards.

examples/go/pagerduty-trigger/handler/handler.go

embano1

Thx Frankie, great contribution!

docs/site/examples.md

examples/go/pagerduty-trigger/handler/testdata/invalid-event-1.json

examples/go/pagerduty-trigger/stack.yml

examples/go/pagerduty-trigger/handler/types.go

examples/go/pagerduty-trigger/handler/go.sum

examples/go/pagerduty-trigger/handler/handler.go

embano1 · 2020-09-18T11:06:16Z

Once all comments are resolved, please sign and squash the commits.

Signed-off-by: codegold79 <fgold@vmware.com>

codegold79 · 2020-09-21T19:35:08Z

@embano1 I made the changes and put all the commits into one. I realized that I did that a little early as you haven't had a chance to re-review. Sorry about that. Hopefully, this function example is short/simple enough that looking through the code again won't be too much of a hassle.

embano1

Two minor things, but we can keep note of them in PR and change if required in a separate PR.

embano1 · 2020-09-23T19:28:52Z

examples/go/pagerduty-trigger/handler/handler.go

+		return []byte{}, fmt.Errorf("read http response body: %w", err)
+	}
+
+	if res.StatusCode < 200 || res.StatusCode >= 300 {


3xx does not necessarily have to be an error condition.

Good point. I'll change that to not include 3xx.

embano1 · 2020-09-23T19:29:11Z

examples/go/pagerduty-trigger/handler/handler.go

+}
+
+func pdSendRequest(ctx context.Context, path string, pdp pdPayload) ([]byte, error) {
+	clt := &http.Client{}


It's best practice to create the client with some same timeouts.

Definite yes to that suggestion. I'll add a timeout.

Signed-off-by: codegold79 <fgold@vmware.com>

embano1 · 2020-09-24T08:57:59Z

examples/go/pagerduty-trigger/handler/handler.go

+
+	reqBody, err := json.Marshal(pdp)
+	if err != nil {
+		return []byte{}, err


Nit: These returns could be simplified with return nil, err

embano1

Left a comment (nit) which can be fixed in a future PR.

* Add go-pagerduty-trigger handle function example using Go Signed-off-by: codegold79 <fgold@vmware.com>

codegold79 added documentation Improvements or additions to documentation enhancement New feature or request dco-required labels Sep 16, 2020

codegold79 requested review from dlinsley, embano1, pksrc and vladi-velikov September 16, 2020 23:03

vmwclabot removed the dco-required label Sep 16, 2020

codegold79 requested a review from martindekov September 16, 2020 23:18

martindekov previously approved these changes Sep 17, 2020

View reviewed changes

examples/go/pagerduty-trigger/handler/handler.go Outdated Show resolved Hide resolved

examples/go/pagerduty-trigger/handler/handler.go Outdated Show resolved Hide resolved

embano1 reviewed Sep 18, 2020

View reviewed changes

Add go-pagerduty-trigger handle function example using Go

3f0116a

Signed-off-by: codegold79 <fgold@vmware.com>

codegold79 dismissed martindekov’s stale review via 3f0116a September 21, 2020 19:32

codegold79 force-pushed the pagerduty-trigger-example-in-go branch from d5c78fa to 3f0116a Compare September 21, 2020 19:32

codegold79 requested review from embano1 and martindekov September 21, 2020 19:35

embano1 previously approved these changes Sep 23, 2020

View reviewed changes

embano1 changed the title ~~Pagerduty trigger example in go~~ Add Pagerduty trigger example in go Sep 23, 2020

codegold79 dismissed embano1’s stale review via 2cc6196 September 23, 2020 20:54

codegold79 requested a review from embano1 September 23, 2020 22:14

Add http client timeout and adjust error code

1ff3a7e

Signed-off-by: codegold79 <fgold@vmware.com>

codegold79 force-pushed the pagerduty-trigger-example-in-go branch from 2cc6196 to 1ff3a7e Compare September 23, 2020 22:16

embano1 reviewed Sep 24, 2020

View reviewed changes

embano1 approved these changes Sep 24, 2020

View reviewed changes

embano1 merged commit 88b878c into vmware-samples:development Sep 24, 2020

rapuli pushed a commit to rapuli/vcenter-event-broker-appliance that referenced this pull request Oct 30, 2020

Add Pagerduty trigger example in go (vmware-samples#201)

ffe9a7e

* Add go-pagerduty-trigger handle function example using Go Signed-off-by: codegold79 <fgold@vmware.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Pagerduty trigger example in go #201

Add Pagerduty trigger example in go #201

codegold79 commented Sep 16, 2020

martindekov left a comment

embano1 left a comment

embano1 commented Sep 18, 2020

codegold79 commented Sep 21, 2020

embano1 left a comment

embano1 Sep 23, 2020

codegold79 Sep 23, 2020

embano1 Sep 23, 2020

codegold79 Sep 23, 2020 •

edited

Loading

embano1 Sep 24, 2020

embano1 left a comment

Add Pagerduty trigger example in go #201

Add Pagerduty trigger example in go #201

Conversation

codegold79 commented Sep 16, 2020

Summary

Pull Request Checklist

Change Type

Resolved Issues

Testing Verification

Additional Information

martindekov left a comment

Choose a reason for hiding this comment

embano1 left a comment

Choose a reason for hiding this comment

embano1 commented Sep 18, 2020

codegold79 commented Sep 21, 2020

embano1 left a comment

Choose a reason for hiding this comment

embano1 Sep 23, 2020

Choose a reason for hiding this comment

codegold79 Sep 23, 2020

Choose a reason for hiding this comment

embano1 Sep 23, 2020

Choose a reason for hiding this comment

codegold79 Sep 23, 2020 • edited Loading

Choose a reason for hiding this comment

embano1 Sep 24, 2020

Choose a reason for hiding this comment

embano1 left a comment

Choose a reason for hiding this comment

codegold79 Sep 23, 2020 •

edited

Loading