Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make antrea-agent tolerant of NoExecute taints #815

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Jun 9, 2020

As a node-critical Pod, antrea-agent should be tolerant of all NoExecute
taints regardless of their keys like kube-proxy and other CNIs do,
otherwise workload Pods' network won't work once antrea-agent is evicted.

Fixes #814

As a node-critical Pod, antrea-agent should be tolerant of all NoExecute
taints regardless of their keys like kube-proxy and other CNIs do,
otherwise workload Pods' network won't work once antrea-agent is evicted.
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@tnqn
Copy link
Member Author

tnqn commented Jun 9, 2020

/test-all

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn merged commit f93ba17 into antrea-io:master Jun 10, 2020
@tnqn tnqn deleted the noexecute-taint branch June 10, 2020 04:50
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
As a node-critical Pod, antrea-agent should be tolerant of all NoExecute
taints regardless of their keys like kube-proxy and other CNIs do,
otherwise workload Pods' network won't work once antrea-agent is evicted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

antrea-agent shouldn't get evicted by "NoExecute" taint
4 participants