From cd6a1b458a0c441e21d6492091e923ae6406ee04 Mon Sep 17 00:00:00 2001
From: Marty Spiewak <mspiewak@vmware.com>
Date: Thu, 17 Feb 2022 16:38:59 -0500
Subject: [PATCH] Remove error log when resource is deleted

---
 pkg/repository/repository.go      |  1 -
 pkg/repository/repository_test.go | 20 +++++++++++++++-----
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/pkg/repository/repository.go b/pkg/repository/repository.go
index 110e333db..0a567d4b7 100644
--- a/pkg/repository/repository.go
+++ b/pkg/repository/repository.go
@@ -393,7 +393,6 @@ func (r *repository) getObject(ctx context.Context, name string, namespace strin
 	)
 	if err != nil {
 		namespacedName := getNamespacedName(name, namespace)
-		log.Error(err, "failed to get object from api server", "object", namespacedName)
 		return fmt.Errorf("failed to get object [%s] from api server: %w", namespacedName, err)
 	}
 
diff --git a/pkg/repository/repository_test.go b/pkg/repository/repository_test.go
index b8e14f3f6..2d823fff5 100644
--- a/pkg/repository/repository_test.go
+++ b/pkg/repository/repository_test.go
@@ -634,10 +634,12 @@ spec:
 					)
 					cl.GetReturns(apiError)
 				})
-				It("returns a nil result without error", func() {
+				It("returns a nil result without error and without logging an error", func() {
 					delivery, err := repo.GetDelivery(ctx, "my-delivery")
 					Expect(err).NotTo(HaveOccurred())
 					Expect(delivery).To(BeNil())
+
+					Expect(out.Contents()).To(BeEmpty())
 				})
 			})
 
@@ -996,10 +998,12 @@ spec:
 			})
 
 			Context("workload doesnt exist", func() {
-				It("returns nil workload", func() {
+				It("returns nil workload without logging an error", func() {
 					workload, err := repo.GetWorkload(ctx, "workload-that-does-not-exist-name", "workload-namespace")
 					Expect(err).NotTo(HaveOccurred())
 					Expect(workload).To(BeNil())
+
+					Expect(out.Contents()).To(BeEmpty())
 				})
 			})
 		})
@@ -1022,10 +1026,12 @@ spec:
 			})
 
 			Context("deliverable doesnt exist", func() {
-				It("returns nil deliverable", func() {
+				It("returns nil deliverable without logging an error", func() {
 					deliverable, err := repo.GetDeliverable(ctx, "deliverable-that-does-not-exist-name", "deliverable-namespace")
 					Expect(err).NotTo(HaveOccurred())
 					Expect(deliverable).To(BeNil())
+
+					Expect(out.Contents()).To(BeEmpty())
 				})
 			})
 		})
@@ -1048,10 +1054,12 @@ spec:
 			})
 
 			Context("runnable doesnt exist", func() {
-				It("returns nil runnable", func() {
+				It("returns nil runnable without logging an error", func() {
 					runnable, err := repo.GetRunnable(ctx, "runnable-that-does-not-exist-name", "runnable-namespace")
 					Expect(err).NotTo(HaveOccurred())
 					Expect(runnable).To(BeNil())
+
+					Expect(out.Contents()).To(BeEmpty())
 				})
 			})
 		})
@@ -1073,10 +1081,12 @@ spec:
 			})
 
 			Context("supply chain doesnt exist", func() {
-				It("returns no error", func() {
+				It("returns no error without logging an error", func() {
 					sc, err := repo.GetSupplyChain(ctx, "sc-that-does-not-exist-name")
 					Expect(err).ToNot(HaveOccurred())
 					Expect(sc).To(BeNil())
+
+					Expect(out.Contents()).To(BeEmpty())
 				})
 			})
 		})