-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velero]: add template for generating node-agent with prefix of release name #599
Conversation
b5f7111
to
e432908
Compare
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
e432908
to
68fcfe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
apologies @jenting - had to re-push to fix a mistake I made in copying over from one of the other templates - should be all good to go now. cheers |
Could you help resolve the conflict, thanks. |
@1602077 @jenting Currently, the Velero code uses the hardcoded names of Velero deployment and Node Agent daemonset to do some checking (e.g. checking whether node-agent is starting up before doing the file system backup), changing the names will break these features. |
@ywk253100 okay - cheers for the update. Will close this one out for now then. |
Special notes for your reviewer:
When installing velero as a part of an umbrella helm the node-agent daemonset name does not respect the helm release name as it is hard coded in the template definition.
This makes the lineage of the
node-agent
daemonset unclear.i.e.
This PR adds a template which prefixes the release name on the
node-agent
daemonset to be consistent with the velero deployment naming schemeChecklist
[velero]
)