Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero]: add template for generating node-agent with prefix of release name #599

Closed
wants to merge 5 commits into from

Conversation

1602077
Copy link

@1602077 1602077 commented Jul 12, 2024

Special notes for your reviewer:

When installing velero as a part of an umbrella helm the node-agent daemonset name does not respect the helm release name as it is hard coded in the template definition.

This makes the lineage of the node-agent daemonset unclear.

i.e.

$ kubectl get po -n my-release -o name
pod/my-release-velero-b5c66b7d6-lj6l9
pod/node-agent-bqf78

This PR adds a template which prefixes the release name on the node-agent daemonset to be consistent with the velero deployment naming scheme

Checklist

Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
jenting
jenting previously approved these changes Jul 14, 2024
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
@1602077
Copy link
Author

1602077 commented Jul 15, 2024

apologies @jenting - had to re-push to fix a mistake I made in copying over from one of the other templates - should be all good to go now. cheers

@1602077 1602077 requested a review from jenting July 15, 2024 08:32
@jenting
Copy link
Collaborator

jenting commented Jul 22, 2024

Could you help resolve the conflict, thanks.

@ywk253100
Copy link
Contributor

@1602077 @jenting Currently, the Velero code uses the hardcoded names of Velero deployment and Node Agent daemonset to do some checking (e.g. checking whether node-agent is starting up before doing the file system backup), changing the names will break these features.
@1602077 Suggest open an issue in the Velero repository first if this is reasonable requirement for you

@1602077
Copy link
Author

1602077 commented Aug 12, 2024

@ywk253100 okay - cheers for the update. Will close this one out for now then.

@1602077 1602077 closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants