Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to only use default values when the chart has a custom values file #6564

Open
ffdfgdfg opened this issue Aug 3, 2023 · 5 comments
Open
Labels
component/ui Issue related to kubeapps UI good first issue kind/enhancement An issue that reports an enhancement for an implemented feature
Milestone

Comments

@ffdfgdfg
Copy link

ffdfgdfg commented Aug 3, 2023

Summary
The chart has a custom values file, and dashboard only display custom values, but I want to use defaults.

Background and rationale

Description
I deployed rook-ceph-cluster with default values via kubeapps. After they added an external custom values file, upgrade form only display custom values, that's leads wrong values.
Deploy new rook-ceph-cluster chart also uses custom values and not usable.
Additional context
I tried rollback to v2.6.0, but when I click into upgrade, shows An error occurred: Document with errors cannot be stringified. , it's ok in v2.8.0

@ffdfgdfg ffdfgdfg added the kind/question An issue that reports a question about the project label Aug 3, 2023
@absoludity
Copy link
Contributor

Oh - interesting. Yes, we added a feature so that companies can add a custom values file to charts to have those values (merged with the defaults) presented to users, but hadn't anticipated public charts to add custom value files for their own uses.

Currently if there is more than one custom value file, we present a drop-down to choose from, but if there is only one, we do not provide any options.

Two options I can imagine working into the future:

  • require a specifically named custom file for Kubeapps to assume it should be presented by default (such as values-kubeapps-default.yaml), or
  • Always use a drop-down (but this isn't great for the original use-case.

Any objections to updating this functionality to require the specific filename for Kubeapps to present it as the default? I think that better suits the original use-case for that feature, and ensures we avoid this unexpected behaviour.

@absoludity absoludity added kind/bug An issue that reports a defect in an existing feature good first issue labels Aug 4, 2023
@absoludity
Copy link
Contributor

Added the good first issue label as the fix, if agreed as above, should be straight forward and a good intro to the code-base for anyone interested.

@ffdfgdfg
Copy link
Author

ffdfgdfg commented Aug 4, 2023

If the specifically named custom file not exists, will kubeapps use default values?

@absoludity
Copy link
Contributor

If the specifically named custom file not exists, will kubeapps use default values?

Yes, that's what I'm proposing: Kubeapps will always display the chart default values.yaml values unless

  • a file specifically named values-kubeapps-default.yaml is present, in which case it will be used instead, or
  • multiple values-([a-z1-9]+).yaml files exist, in which case a drop-down selector will be displayed for those files (as is the case currently).

@ffdfgdfg
Copy link
Author

ffdfgdfg commented Aug 4, 2023

Excellent! Thank you.

@antgamdia antgamdia added this to the Custom values milestone Aug 8, 2023
@antgamdia antgamdia added component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature and removed kind/question An issue that reports a question about the project kind/bug An issue that reports a defect in an existing feature labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issue related to kubeapps UI good first issue kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Status: 🗒 Todo
Development

No branches or pull requests

3 participants