v1.13.0 changes velero_backup_last_status metric

[wanddynosios]

What steps did you take and what happened:

After upgrading to velero v1.13.0, the velero_backup_last_status metric seems to have changed.

Before, the metric was constant:

Now, it is constantly increasing until the next backup is run:

The last backup did complete without any issues:

velero-my-backup-20240202020000   Completed   0        0          2024-02-02 03:00:00 +0100 CET   27d       default            <none>

What did you expect to happen:
The metric stays the same.

The following information will help us better understand what's going on:
The issue occurs directly after the update, without a new backup being created.

Anything else you would like to add:

Environment:

• Velero version (use velero version): v1.13.0
• Velero features (use velero client config get features): features:
• Kubernetes version (use kubectl version): v1.28.4-eks-8cb36c9
• Cloud provider or hardware configuration: aws eks 1.28
• OS (e.g. from /etc/os-release): amazon_linux:2

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• 👍 for "I would like to see this bug fixed as soon as possible"
• 👎 for "There are more important bugs to focus on right now"

[pixiono]

Hi,

I also took a look into this issue.
I found this PR, which has changed the behavior of the metric. The merge has also been published with the new release: Release diff.

I assume that the value is now increased by 1 with each reconciliation instead of returning 1 as default.

[allenxu404]

@pixiono Yes, the code changes on this PR appears to be in conflict with the existing logic in schedule_controller:

velero/pkg/controller/schedule_controller.go

Line 105 in 3b8370e

c.metrics.InitSchedule(schedule.Name)

the value of velero_backup_last_status metrics increases every time the schedule controller reconciles.

I will fix it, thanks for reporting.