Make pkg/install/Deployment podTemplateOptions bool functions accept bool param #7379
Comments
kaovilai
changed the title
danfengliu
added
the
Enhancement/Dev
|
@kaovilai Could you explain a bit about |
installDeployment := install.Deployment(veleroDeployment.Namespace,
install.WithResources(veleroResourceReqs),
install.WithImage(getVeleroImage(dpa)),
install.WithAnnotations(podAnnotations),
install.WithFeatures(dpa.Spec.Configuration.Velero.FeatureFlags),
install.WithUploaderType(uploaderType),
// last label overrides previous ones
install.WithLabels(veleroDeployment.Labels),
// use WithSecret false even if we have secret because we use a different VolumeMounts and EnvVars
// see: https://github.com/vmware-tanzu/velero/blob/ed5809b7fc22f3661eeef10bdcb63f0d74472b76/pkg/install/deployment.go#L223-L261
// our secrets are appended to containers/volumeMounts in credentials.AppendPluginSpecificSpecs function
install.WithSecret(false),
install.WithServiceAccountName(common.Velero),
)It is not possible to dynamically define true/false for SnapshotMoveData for example because it does not currently accepts a bool param. Here's an example 1 of what I could do with exported PodTemplateOptions exampleArrayOfOptions := []install.podTemplateOptions{ // This cannot be done because podTemplateOptions is not exported
install.WithResources(veleroResourceReqs),
install.WithImage(getVeleroImage(dpa)),
install.WithAnnotations(podAnnotations),
}
if snapMoveData {
exampleArrayOfOptions = append(exampleArrayOfOptions, install.WithDefaultSnapshotMoveData())
}
installDeployment := install.Deployment(exampleArrayOfOptions...)Example 2 - if all bool podTemplateOptions funcs accepts bool, I can pass snapMoveData bool into it without exporting podTemplateOptions type. installDeployment := install.Deployment(
install.WithResources(veleroResourceReqs),
install.WithImage(getVeleroImage(dpa)),
install.WithAnnotations(podAnnotations),
install.WithDefaultSnapshotMoveDataBool(snapMoveData),
) |
|
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands. |
|
unstale |
|
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands. |
|
unstale |
Describe the problem/challenge you have
Since podTemplateOptions is not exported, it is not possible to form an array of podTemplateOptions to pass to install.Deployment().
Anyone using this package would require each exported function that returns an unexported type to be used directly in install.Deployment().
Thus it would be good to make these functions flexible for use by other go packages.
Describe the solution you'd like
Either make all bool related funcs accept bool param, or export the type so an array can be formed dynamically.
Anything else you would like to add:
Environment:
velero version):kubectl version):/etc/os-release):Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
The text was updated successfully, but these errors were encountered: