This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Fix issue #1188: vmgroup is not removable when vms are added from both ESXs #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h ESXs (See original PR #1214 for the details of review comments)
pshahzeb
reviewed
May 9, 2017
esx_service/utils/test_utils.py
Outdated
| auth_api._tenant_vm_rm(name=name, | ||
| vm_list=vm_names) | ||
| auth_api._tenant_rm(name=name, | ||
| remove_volumes=True) |
There was a problem hiding this comment.
nit: no new line at the end.
|
@pshahzeb @shuklanirdesh82 The CI test has passed: https://ci.vmware.run/vmware/docker-volume-vsphere/95 |
shuklanirdesh82
approved these changes
May 10, 2017
| error_info = auth_api._tenant_vm_rm(name=self.tenant1_new_name, | ||
| vm_list=vm_list) | ||
| self.assertEqual(None, error_info) | ||
|
|
||
| error_info = auth_api._tenant_rm( |
There was a problem hiding this comment.
can we use test_utils.cleanup_tenant to keep it consistent?
There was a problem hiding this comment.
Sure, will address.
|
Thanks @shaominchen for addressing quickly! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR was created for a clean commit history. See original PR #1214 for test result and previous review comments)