Fix Test_NsxtSecurityGroupGetAssociatedVms (#498)

vmware · Aug 23, 2022 · ea81c49 · ea81c49
1 parent f67f632
commit ea81c49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.changes/v2.17.0/498-improvements.md b/.changes/v2.17.0/498-improvements.md
@@ -0,0 +1 @@
+* Fix Test_NsxtSecurityGroupGetAssociatedVms which had name clash [GH-498]
diff --git a/govcd/nsxt_firewall_group_static_security_group_test.go b/govcd/nsxt_firewall_group_static_security_group_test.go
@@ -126,7 +126,7 @@ func (vcd *TestVCD) Test_NsxtSecurityGroupGetAssociatedVms(check *C) {
 
 	// VMs are prependend to cleanup list to make sure they are removed before routed network
 	standaloneVm := createStandaloneVm(check, vcd, nsxtVdc, routedNet)
-	PrependToCleanupList(standaloneVm.VM.ID, "standaloneVm", "", check.TestName())
+	PrependToCleanupList(standaloneVm.VM.ID, "standaloneVm", "", standaloneVm.VM.Name)
 
 	secGroupDefinition := &types.NsxtFirewallGroup{
 		Name:           check.TestName(),
@@ -208,10 +208,10 @@ func createNsxtRoutedNetwork(check *C, vcd *TestVCD, vdc *Vdc, edgeGatewayId str
 
 func createStandaloneVm(check *C, vcd *TestVCD, vdc *Vdc, net *OpenApiOrgVdcNetwork) *VM {
 	params := types.CreateVmParams{
-		Name:    check.TestName(),
+		Name:    check.TestName() + "-standalone",
 		PowerOn: false,
 		CreateVm: &types.Vm{
-			Name:                   check.TestName(),
+			Name:                   check.TestName() + "-standalone",
 			VirtualHardwareSection: nil,
 			NetworkConnectionSection: &types.NetworkConnectionSection{
 				Info:                          "Network Configuration for VM",
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* Fix Test_NsxtSecurityGroupGetAssociatedVms which had name clash [GH-498]