Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation procedure in README.md #902

Merged
merged 2 commits into from
Oct 28, 2017

Conversation

tanishi
Copy link
Contributor

@tanishi tanishi commented Oct 27, 2017

Add installation procedure in README.md for user

@vmwclabot
Copy link
Member

@tanishi, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

README.md Outdated
## Installation

`go get github.com/vmware/govmomi`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add the -u flag and use the same markup as: https://github.com/vmware/govmomi/tree/master/govc#source

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks review!

@vmwclabot
Copy link
Member

@tanishi, VMware has approved your signed contributor license agreement.

@tanishi
Copy link
Contributor Author

tanishi commented Oct 28, 2017

I modified. Do I understand it properly?
Please review:bow:

@dougm dougm merged commit 7993445 into vmware:master Oct 28, 2017
@dougm
Copy link
Member

dougm commented Oct 28, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants