Implemented vm.upgrade operation. #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
reviewed
Nov 14, 2017
govc/vm/upgrade.go
Outdated
| } | ||
| err = task.Wait(ctx) | ||
| if err != nil { | ||
| if err.Error() == "Virtual machine compatibility is already up-to-date." { |
There was a problem hiding this comment.
Rather than check the message string, you should be able to use:
func isAlreadyUpgraded(err error) bool {
if fault, ok := err.(task.Error); ok {
_, ok = fault.Fault().(*types.AlreadyUpgraded)
return ok
}
return false
}Then:
if err != nil {
if isAlreadyUpraded(err) {
fmt.Println(err.Error())
}
}
govc/vm/upgrade.go
Outdated
| return err | ||
| } | ||
|
|
||
| var target_version = "" |
There was a problem hiding this comment.
golint warns: don't use underscores in Go names; var target_version should be targetVersion
or you can just name it version
govc/vm/upgrade.go
Outdated
| cmd.VirtualMachineFlag, ctx = flags.NewVirtualMachineFlag(ctx) | ||
| cmd.VirtualMachineFlag.Register(ctx, f) | ||
|
|
||
| f.IntVar(&cmd.version, "version", 0, "Target vm hardware version, by default -- latest available ") |
govc/vm/upgrade.go
Outdated
| } else { | ||
| return err | ||
| } | ||
|
|
govc/vm/upgrade.go
Outdated
| return `Upgrade VMs to latest hardware version | ||
|
|
||
| Examples: | ||
| govc vm.upgrade -vm $vm_name |
There was a problem hiding this comment.
2 space indent instead of tab to match the existing examples format.
|
@pupska, VMware has approved your signed contributor license agreement. |
|
@dougm thanks for your comments, I've pushed updated version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://kb.vmware.com/s/article/1010675