Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Singleton Service][Get pattern by language&region] plurals rule should always follow with language #148

Closed
nannany00 opened this issue Aug 29, 2019 · 2 comments
Assignees
Milestone

Comments

@nannany00
Copy link
Contributor

Singleton Service API:
GET /i18n/api/v2/formatting/pattern (Get pattern from CLDR)

This API is used to provide the pattern data for dates/numbers/currencies/plurals/measurements from CLDR according to the requested language and region.

Plurals rule is related to the translation content, it should always follow with language, as Singleton provides translation by language.


This issue is:
When the combined locale of language and region is valid, the plurals rule is following the combined locale, not language.

Example:
language=pt; region=PT; scope=plurals

Actual Result is:
it will return the plurals rule of pt-PT.

Expected Result is:
it should return the plurals rule of pt.

@nannany00
Copy link
Contributor Author

Based on current code, still has issue here:
When language=pt-PT, region=PT, the plurals rule should be pt-PT, not pt.

Please help to check.

@lyiyu66
Copy link

lyiyu66 commented Sep 25, 2019

Plurals rule issue has been fixed on current code.

@lyiyu66 lyiyu66 closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants