Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Singleton Service] Don't support product-white-list in combination API #322

Closed
nannany00 opened this issue Dec 4, 2019 · 0 comments
Assignees
Milestone

Comments

@nannany00
Copy link
Contributor

Describe the bug
Product-White-List is a new feature for Singleton Service, the detail is: Only defined product(s) in Singleton Service can get translation and supported language list well.
This feature should be added to all APIs that work by productName, but, it doesn't work for Combination API.
**Notes: **
It reproduces on both bundle and s3 build.

To Reproduce
Steps to reproduce the behavior:

  1. Get Singleton Service build based on v0.3.0
  2. Go to API: POST /i18n/api/v2/combination/translationsAndPattern Get translations and patterns
  3. Testing data:
    Product "Testing" is not supported by Singleton Service.
    Request data:
Testing/2.0.0/default/ja

Response data:

  "data": {
    "components": null,
...
}

Expected behavior
Here should return the response like below as same with other APIs:

{
  "code" : 400,
  "message" : "The product 'Testing' is NOT supported yet!",
  "serverTime" : ""
}

Screenshots
NA

Desktop (please complete the following information):
NA

Additional context
NA

@nannany00 nannany00 added this to the Sprint 71 milestone Dec 4, 2019
@gong-yu gong-yu modified the milestones: Sprint 71, Sprint 72 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants