Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Singleton Service APIs] Remove fallback to en content when the translation no exist for request locale #468

Closed
nannany00 opened this issue Mar 23, 2020 · 1 comment
Assignees
Labels
area/java-service kind/enhancement Enhancement to existing features
Milestone

Comments

@nannany00
Copy link
Contributor

Singleton Service translation-related APIs. it has a function to fallback the translation to EN content when no translaiton exist for request locale. But it's not flexible when the source locale is not English for product, so we remove this in Singleton Service, and let Singleton Client do which content will be returned when translaiton is not ready.

@nannany00 nannany00 added area/java-service kind/enhancement Enhancement to existing features labels Mar 23, 2020
@nannany00
Copy link
Contributor Author

Based on our current user usage, we only do this change for v2 API that Singleton Client used:
GET /i18n/api/v2/translation/products/{productName}/versions/{version}/locales/{locale}/components/{component}

@gong-yu gong-yu added this to the Sprint 78 milestone Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/java-service kind/enhancement Enhancement to existing features
Projects
None yet
Development

No branches or pull requests

3 participants