Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review what's being bundled in rainbowkit-wallets #185

Open
elboletaire opened this issue Jul 1, 2024 · 0 comments
Open

Review what's being bundled in rainbowkit-wallets #185

elboletaire opened this issue Jul 1, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request rainbowkit-wallets

Comments

@elboletaire
Copy link
Member

React is being bundled, among other dependencies that could be added as peer dependencies and imported by the end developer.

Trying to remove it by adding it to peer dependencies causes the final bundle to fail, since it tries to import react dynamically and it simply crashes. The react-modal package used may be doing something wrong, and changing it to a chakra-ui/modal may be required to properly ignore react in the final bundle.

@elboletaire elboletaire added enhancement New feature or request bug Something isn't working rainbowkit-wallets labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request rainbowkit-wallets
Projects
None yet
Development

No branches or pull requests

1 participant