Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: review updates (COR-0000) #350

Closed
wants to merge 4 commits into from
Closed

fix: review updates (COR-0000) #350

wants to merge 4 commits into from

Conversation

gillyb
Copy link
Contributor

@gillyb gillyb commented Nov 22, 2024

Addresses:

  • COR-4006
  • COR-4007
  • COR-4009

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 3:10pm

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 22, 2024

Your org requires the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gillyb gillyb added the merge label Nov 25, 2024
@gillyb Graphite App
Copy link
Contributor Author

gillyb commented Nov 25, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 25, 11:12 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 11:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 25, 11:13 AM EST: CI is running for this PR on a draft PR: #357
  • Nov 25, 11:18 AM EST: CI is running for this PR on a draft PR: #358
  • Nov 25, 11:26 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #358.

gillyb added a commit that referenced this pull request Nov 25, 2024
@gillyb
fix: review updates (COR-0000) (#350)
2713e26 
Addresses:

* COR-4006
* COR-4007
* COR-4009
gillyb added a commit that referenced this pull request Nov 25, 2024
@gillyb
fix: review updates (COR-0000) (#350)
4856dd4 
Addresses:

* COR-4006
* COR-4007
* COR-4009
@graphite-app graphite-app bot closed this Nov 25, 2024
@graphite-app graphite-app bot deleted the Gilly/ui-review-again/COR-0000 branch November 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaalnaik mikaalnaik mikaalnaik approved these changes

Assignees
No one assigned
Labels
merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gillyb @mikaalnaik