fix: allow custom css stylesheets (CT-000) #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecathectZero
commented
Oct 26, 2023
| @@ -26,5 +26,6 @@ export const sanitizeConfig = (config: unknown): Partial<ChatConfig> & Pick<Chat | |||
| ...(typeof user.image === 'string' && { image: user.image }), | |||
| }, | |||
| }), | |||
| ...(isObject(assistant) && ({ assistant } as Partial<Pick<ChatConfig, 'assistant'>>)), | |||
There was a problem hiding this comment.
we now allow users to add an assistant option the config and override stuff set on VF's webchat settings dashboard.
effervescentia
approved these changes
Oct 26, 2023
viniciusdacal
approved these changes
Oct 26, 2023
Comment on lines
10
to
12
| link.href = url; | ||
|
|
||
| const load = new Promise((resolve, reject) => { | ||
| link.onload = resolve; | ||
| link.onerror = reject; | ||
| }); |
There was a problem hiding this comment.
I don't think this is possible, but technically, the resource starts loading right when you set the href attribute. So, in case the resource is already cached, the order of .href and .onload definitions could matter. Again, I don't think that's possible, because of event loop, and even the time it would take to load the cached resource, but better to be safe than sorry.
Suggested change
| link.href = url; | |
| const load = new Promise((resolve, reject) => { | |
| link.onload = resolve; | |
| link.onerror = reject; | |
| }); | |
| const load = new Promise((resolve, reject) => { | |
| link.onload = resolve; | |
| link.onerror = reject; | |
| }); | |
| link.href = url; |
|
bors r+ |
bors-vf bot
added a commit
that referenced
this pull request
Oct 26, 2023
80: fix: allow custom css stylesheets (CT-000) r=DecathectZero a=DecathectZero
Users can now initialize stylesheets like this:
```
window.voiceflow.chat.load({
...
assistant: {
stylesheet: 'http://test.com/test.css',
},
});
```
This leaves the path open to expose this on the GUI in the future since it is part of the `Assistant` object type.
This is necessary just because of how iframes don't handle root page styles. This stylesheet gets injected both into the main page AND the iframe
Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"This branch must not contain merge commits.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
bors-vf bot
added a commit
that referenced
this pull request
Oct 26, 2023
80: fix: allow custom css stylesheets (CT-000) r=DecathectZero a=DecathectZero
Users can now initialize stylesheets like this:
```
window.voiceflow.chat.load({
...
assistant: {
stylesheet: 'http://test.com/test.css',
},
});
```
This leaves the path open to expose this on the GUI in the future since it is part of the `Assistant` object type.
This is necessary just because of how iframes don't handle root page styles. This stylesheet gets injected both into the main page AND the iframe
Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"This branch must not contain merge commits. 2 of 2 required status checks are expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
DecathectZero
force-pushed
the
tyler/add-css-stylesheet/CT-000
branch
from
15aaa42
to
121b871
Compare
|
bors r+ |
bors-vf bot
added a commit
that referenced
this pull request
Oct 26, 2023
80: fix: allow custom css stylesheets (CT-000) r=DecathectZero a=DecathectZero
Users can now initialize stylesheets like this:
```
window.voiceflow.chat.load({
...
assistant: {
stylesheet: 'http://test.com/test.css',
},
});
```
This leaves the path open to expose this on the GUI in the future since it is part of the `Assistant` object type.
This is necessary just because of how iframes don't handle root page styles. This stylesheet gets injected both into the main page AND the iframe
Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"This branch must not contain merge commits. 2 of 2 required status checks have not succeeded: 1 expected and 1 pending.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now initialize stylesheets like this:
This leaves the path open to expose this on the GUI in the future since it is part of the
Assistantobject type.This is necessary just because of how iframes don't handle root page styles. This stylesheet gets injected both into the main page AND the iframe