From 3008f7ef29e0a5593f6f0afbdc9343f573f1a375 Mon Sep 17 00:00:00 2001 Patch-Source: https://github.com/dotnet/installer/pull/14816 From: Antoine Martin Date: Tue, 15 Nov 2022 01:04:07 -0500 Subject: [PATCH 1/3] Eliminate runtime portable build (backport dotnet#14549) --- .../tarball/content/Directory.Build.props | 8 -- .../tarball/content/repos/aspnetcore.proj | 1 + .../tarball/content/repos/installer.proj | 2 +- .../tarball/content/repos/known-good.proj | 1 - .../content/repos/runtime-portable.proj | 47 ----------- .../content/repos/runtime.common.props | 43 ---------- .../content/repos/runtime.common.targets | 46 ----------- .../tarball/content/repos/runtime.proj | 82 ++++++++++++++++++- .../source-build-reference-packages.proj | 4 +- src/redist/targets/Crossgen.targets | 2 +- src/redist/targets/GenerateLayout.targets | 3 + 11 files changed, 88 insertions(+), 151 deletions(-) delete mode 100644 repos/runtime-portable.proj delete mode 100644 repos/runtime.common.props delete mode 100644 repos/runtime.common.targets diff --git a/Directory.Build.props b/Directory.Build.props index 61cc6ff67..2e2d7e8bc 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -22,14 +22,6 @@ x64 false - - - false - false - true - false diff --git a/repos/aspnetcore.proj b/repos/aspnetcore.proj index 480f3c713..52243024a 100644 --- a/repos/aspnetcore.proj +++ b/repos/aspnetcore.proj @@ -9,6 +9,7 @@ $(BuildCommandArgs) --no-build-repo-tasks $(BuildCommandArgs) /p:BuildNodeJs=false $(BuildCommandArgs) /p:PublishCompressedFilesPathPrefix=$(SourceBuiltAspNetCoreRuntime) + $(BuildCommandArgs) /p:PortableBuild=false /p:TargetRuntimeIdentifier=$(TargetRid) $(BuildCommandArgs) /p:MicrosoftNetFrameworkReferenceAssembliesVersion=1.0.0 diff --git a/repos/installer.proj b/repos/installer.proj index e34337b85..6c08a1f67 100644 --- a/repos/installer.proj +++ b/repos/installer.proj @@ -25,7 +25,7 @@ $(BuildCommandArgs) /p:Rid=$(TargetRid) $(BuildCommandArgs) /p:DOTNET_INSTALL_DIR=$(DotNetCliToolDir) - $(BuildCommandArgs) /p:AspNetCoreInstallerRid=linux-$(Platform) + $(BuildCommandArgs) /p:AspNetCoreInstallerRid=$(TargetRid) $(BuildCommandArgs) /p:CoreSetupRid=freebsd-x64 /p:PortableBuild=true $(BuildCommandArgs) /p:CoreSetupRid=osx-x64 diff --git a/repos/known-good.proj b/repos/known-good.proj index eab516290..12d9943da 100644 --- a/repos/known-good.proj +++ b/repos/known-good.proj @@ -44,7 +44,6 @@ - diff --git a/repos/runtime.proj b/repos/runtime.proj index f3ed143f8..efd8b66fa 100644 --- a/repos/runtime.proj +++ b/repos/runtime.proj @@ -1,18 +1,53 @@ - + + + true + + $(ProjectDirectory)/clean$(ShellExtension) + $(TargetRid) osx-x64 freebsd-x64 win-x64 + <_platformIndex>$(NETCoreSdkRuntimeIdentifier.LastIndexOf('-')) + $(NETCoreSdkRuntimeIdentifier.Substring(0, $(_platformIndex))) + + <_platformIndex>$(NETCoreSdkPortableRuntimeIdentifier.LastIndexOf('-')) + $(NETCoreSdkPortableRuntimeIdentifier.Substring(0, $(_platformIndex))) + $(StandardSourceBuildArgs) $(BuildCommandArgs) /p:TargetRid=$(OverrideTargetRid) + $(BuildCommandArgs) /p:RuntimeOS=$(RuntimeOS) + $(BuildCommandArgs) /p:BaseOS=$(BaseOS) $(BuildCommandArgs) /p:SourceBuildNonPortable=true $(StandardSourceBuildCommand) $(BuildCommandArgs) + + + $(ProjectDirectory)global.json + $(ProjectDirectory)NuGet.config + false + true + + + + + + + + + + + + + + + + @@ -20,8 +55,49 @@ - - + + + + + + + + + + + + + $(ProjectDirectory)pkg/Microsoft.NETCore.Platforms/runtime.json + + + + + + + + + <_builtRuntimePackages Include="$(SourceBuiltAssetsDir)*.symbols.nupkg" /> + <_builtRuntimePackages> + $([System.String]::Copy('%(FileName)').Replace('symbols', 'nupkg')) + + + + + + + + + + + diff --git a/repos/source-build-reference-packages.proj b/repos/source-build-reference-packages.proj index 69ab564a2..9545b50e4 100644 --- a/repos/source-build-reference-packages.proj +++ b/repos/source-build-reference-packages.proj @@ -2,7 +2,9 @@ - $(StandardSourceBuildCommand) $(StandardSourceBuildArgs) + $(StandardSourceBuildArgs) + $(BuildCommandArgs) /p:MicrosoftNetCoreIlasmPackageRuntimeId=$(NETCoreSdkRuntimeIdentifier) + $(StandardSourceBuildCommand) $(BuildCommandArgs) $(ProjectDirectory)NuGet.config $(ProjectDirectory)global.json -- 2.38.2 From 94463478bd6aaec208bc5e3dd1d120e0a49aeaaa Mon Sep 17 00:00:00 2001 Patch-Source: https://github.com/dotnet/installer/pull/14816 From: Antoine Martin Date: Tue, 15 Nov 2022 01:08:29 -0500 Subject: [PATCH 3/3] source-build: stop overriding aspnetcore version (backport of #14938) --- .../tarball/content/Directory.Build.props | 4 ---- .../tarball/content/tools-local/init-build.proj | 12 ++++++++++++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 2e2d7e8bc..6b08fa71b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -222,12 +222,8 @@ - - - - diff --git a/tools-local/init-build.proj b/tools-local/init-build.proj index 701f76c0c..ac4508947 100644 --- a/tools-local/init-build.proj +++ b/tools-local/init-build.proj @@ -9,6 +9,7 @@ + @@ -22,6 +23,7 @@ + + + + + + -- 2.38.2 From 5ee269eef8bd02d066151deaa4d8c0fe6b6cbce4 Mon Sep 17 00:00:00 2001 Patch-Source: https://github.com/dotnet/installer/pull/14816 From: Antoine Martin Date: Tue, 15 Nov 2022 01:04:46 -0500 Subject: [PATCH 2/3] BundledVersions: update portable rid logic (backport dotnet#14647) --- .../tarball/content/repos/installer.proj | 5 +++++ src/redist/targets/GetRuntimeInformation.targets | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/repos/installer.proj b/repos/installer.proj index 6c08a1f67..95d47c941 100644 --- a/repos/installer.proj +++ b/repos/installer.proj @@ -10,6 +10,10 @@ osx-x64 $(OverrideTargetRid.Substring(0, $(OverrideTargetRid.IndexOf("-")))) + + <_platformIndex>$(NETCoreSdkPortableRuntimeIdentifier.LastIndexOf('-')) + $(NETCoreSdkPortableRuntimeIdentifier.Substring(0, $(_platformIndex))) + --runtime-id $(OverrideTargetRid) --runtime-id $(TargetRid) @@ -22,6 +26,7 @@ --> $(BuildCommandArgs) /p:NETCoreAppMaximumVersion=99.9 $(BuildCommandArgs) /p:OSName=$(OSNameOverride) + $(BuildCommandArgs) /p:PortableOSName=$(PortableOS) $(BuildCommandArgs) /p:Rid=$(TargetRid) $(BuildCommandArgs) /p:DOTNET_INSTALL_DIR=$(DotNetCliToolDir) -- 2.38.2 From 3008f7ef29e0a5593f6f0afbdc9343f573f1a375 Mon Sep 17 00:00:00 2001 Patch-Source: https://github.com/dotnet/installer/pull/14816 From: Antoine Martin Date: Tue, 15 Nov 2022 01:04:07 -0500 Subject: [PATCH 1/3] Eliminate runtime portable build (backport dotnet#14549) --- .../tarball/content/Directory.Build.props | 8 -- .../tarball/content/repos/aspnetcore.proj | 1 + .../tarball/content/repos/installer.proj | 2 +- .../tarball/content/repos/known-good.proj | 1 - .../content/repos/runtime-portable.proj | 47 ----------- .../content/repos/runtime.common.props | 43 ---------- .../content/repos/runtime.common.targets | 46 ----------- .../tarball/content/repos/runtime.proj | 82 ++++++++++++++++++- .../source-build-reference-packages.proj | 4 +- src/redist/targets/Crossgen.targets | 2 +- src/redist/targets/GenerateLayout.targets | 3 + 11 files changed, 88 insertions(+), 151 deletions(-) delete mode 100644 src/SourceBuild/tarball/content/repos/runtime-portable.proj delete mode 100644 src/SourceBuild/tarball/content/repos/runtime.common.props delete mode 100644 src/SourceBuild/tarball/content/repos/runtime.common.targets diff --git a/src/installer/src/redist/targets/Crossgen.targets b/src/installer/src/redist/targets/Crossgen.targets index 8949af132..a59ed388f 100644 --- a/src/installer/src/redist/targets/Crossgen.targets +++ b/src/installer/src/redist/targets/Crossgen.targets @@ -6,7 +6,7 @@ microsoft.netcore.app.runtime.$(SharedFrameworkRid) - microsoft.netcore.app.crossgen2.$(HostOSName)-$(BuildArchitecture) + microsoft.netcore.app.crossgen2.$(Crossgen2Rid) $(NuGetPackageRoot)/$(RuntimeNETCrossgenPackageName)/$(MicrosoftNETCoreAppRuntimePackageVersion)/tools/crossgen2$(ExeExtension) diff --git a/src/installer/src/redist/targets/GenerateLayout.targets b/src/installer/src/redist/targets/GenerateLayout.targets index 88a053b61..ce5e09b69 100644 --- a/src/installer/src/redist/targets/GenerateLayout.targets +++ b/src/installer/src/redist/targets/GenerateLayout.targets @@ -84,6 +84,9 @@ dotnet-runtime$(PgoTerm)-$(VSRedistCommonNetCoreSharedFrameworkx6460PackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) windowsdesktop-runtime-$(MicrosoftWindowsDesktopAppRuntimePackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) + $(HostOSName)-$(BuildArchitecture) + $(SharedFrameworkRid) + $(SharedFrameworkRid) linux-x64 $(AspNetCoreInstallerRid) -- 2.38.2 From 5ee269eef8bd02d066151deaa4d8c0fe6b6cbce4 Mon Sep 17 00:00:00 2001 Patch-Source: https://github.com/dotnet/installer/pull/14816 From: Antoine Martin Date: Tue, 15 Nov 2022 01:04:46 -0500 Subject: [PATCH 2/3] BundledVersions: update portable rid logic (backport dotnet#14647) --- .../tarball/content/repos/installer.proj | 5 +++++ src/redist/targets/GetRuntimeInformation.targets | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/installer/src/redist/targets/GetRuntimeInformation.targets b/src/installer/src/redist/targets/GetRuntimeInformation.targets index a99a7e9da..89f000119 100644 --- a/src/installer/src/redist/targets/GetRuntimeInformation.targets +++ b/src/installer/src/redist/targets/GetRuntimeInformation.targets @@ -9,10 +9,15 @@ osx freebsd linux - + + $(Rid.Substring(0, $(Rid.LastIndexOf('-')))) $(HostOSName) - $(OSName)-$(Architecture) + $(OSName) + + $(OSName)-$(Architecture) + + $(PortableOSName)-$(Architecture) @@ -23,10 +28,9 @@ - $(Rid) - $(OSName)-$(Architecture) + $(Rid) + + $(PortableRid) $(HostOSName)-$(Architecture) -- 2.38.2