Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make all editor settings configurable #78

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Feb 26, 2024

Affected services: css, html, json, markdown, prettyhtml, pug-beautify, pug, sass-formatter, typescript, yaml

  • Most services now expose documentSelector / *DocumentSelector option.

  • Services with formatting capabilities now expose the isFormattingEnabled option.

  • css: now obtains LanguageService instances on demand.

  • css: no longer has built-in support for postcss language. If necessary, you can configure scssDocumentSelector: ['scss', 'postcss'] option.

  • html: if you need to update custom data, now you should implement the onDidChangeCustomData option instead of inject 'html/updateCustomData' key.

Refactoring of the prettier service plugin will be done in a separate PR.

@johnsoncodehk johnsoncodehk marked this pull request as ready for review February 26, 2024 02:18
@johnsoncodehk johnsoncodehk merged commit 292f190 into volar-2.1 Feb 26, 2024
@johnsoncodehk johnsoncodehk deleted the configurable-settings branch February 26, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant