Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): expose FileRegistry in proxyCreateProgram() #128

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

zcf0508
Copy link
Contributor

@zcf0508 zcf0508 commented Jan 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@johnsoncodehk
Copy link
Member

Since this was not the intended use case, I just changed it to be exposed in the internal __volar__ property.

On the other hand, Vue Langauge Tools 2.0 will be migrated to the TS plugin, and ts-type-explorer seems to be based on the TS plugin as well, so it may not need access to Volar's internal API to support this. You might consider using the extension install package from vuejs/language-tools#3789 or the repo master branch to try this out.

@johnsoncodehk johnsoncodehk changed the title feat: expose FileRegistry feat(typescript): expose FileRegistry in proxyCreateProgram() Feb 4, 2024
@johnsoncodehk johnsoncodehk merged commit 780fdd1 into volarjs:master Feb 4, 2024
3 checks passed
@johnsoncodehk johnsoncodehk linked an issue Feb 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] exposing the FileRegistry in 2.0
2 participants