Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(monaco): correct package name resolve #149

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix(monaco): correct package name resolve #149

merged 2 commits into from
Mar 5, 2024

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Mar 2, 2024 •
edited
Loading

  • Should remove /node_modules/ prefix from fileName, not uri
  • Correct package name

@sxzz sxzz marked this pull request as draft March 2, 2024 08:33
@sxzz
Copy link
Contributor Author

sxzz commented Mar 2, 2024 •
edited
Loading

There is more than one bug, hold on

@sxzz sxzz changed the title fix(monaco): remove node_module prefix fix(monaco): ata Mar 2, 2024
@sxzz sxzz changed the title fix(monaco): ata fix(monaco): get package name Mar 2, 2024
@sxzz sxzz marked this pull request as ready for review March 2, 2024 08:53
@johnsoncodehk johnsoncodehk changed the title fix(monaco): get package name fix(monaco): correct package name resolve Mar 5, 2024
@johnsoncodehk johnsoncodehk merged commit 674a7a0 into volarjs:master Mar 5, 2024
@sxzz sxzz deleted the fix/node-modules-prefix branch March 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxzz @johnsoncodehk