feat(language-core): add option to resolve hidden extensions #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machty
reviewed
May 31, 2024
| @@ -52,6 +52,24 @@ export function createResolveModuleName<T>( | |||
| } | |||
| } | |||
| } | |||
| if (typescript.resolveHiddenExtensions && fileName.endsWith(`.d.ts`)) { | |||
There was a problem hiding this comment.
Just for understanding/posterity: I was confused about why we'd be checking .d.ts extension here, given that for an Ember .gts file, there wouldn't be a .d.ts file on disk. But the reason this works is that TS checks for xxx.js, xxx.ts, and then xxx.d.ts. We hook into the check for .d.ts and take that opportunity to check for extra file extensions (such as .gts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
resolveHiddenExtensionsoption toLanguagePlugin#typescript. When enabled,resolveModeNamewill attempt to add extra extensions to resolve's module name.