Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-service): move project context from Language to language service option #217

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Jun 29, 2024

Motivation

Language.typescript is used to pass TS project context to volar-service-typescript. Since Language.typescript is specific to LSP context, it should be pass through language service instead of Language interface.

@johnsoncodehk johnsoncodehk changed the title refactor(language-service): add project context option to language service refactor(language-service): add project context option to create language service Jun 29, 2024
@johnsoncodehk johnsoncodehk changed the title refactor(language-service): add project context option to create language service refactor(language-service): move project context from Language to language service option Jun 29, 2024
@johnsoncodehk johnsoncodehk merged commit 18b92a0 into master Jun 29, 2024
6 checks passed
@johnsoncodehk johnsoncodehk deleted the project-context branch June 29, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant