Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value of PodGroup in admission controller #118

Closed
k82cn opened this issue May 4, 2019 · 6 comments
Closed

Set default value of PodGroup in admission controller #118

k82cn opened this issue May 4, 2019 · 6 comments
Assignees
@TommyLike
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high
Milestone
v0.1

Comments

@k82cn
Copy link
Member

k82cn commented May 4, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Description:

Currently, the default value of PodGroup is set by operator/customized-controller which is inconvenience for developer. It's better to set those default value to PodGroup for all users/developers.
@k82cn
Copy link
Member Author

k82cn commented May 4, 2019

/kind feature

@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 4, 2019
@k82cn
Copy link
Member Author

k82cn commented May 4, 2019

/priority high

@k82cn k82cn added this to the v0.1 milestone May 4, 2019
@k82cn
Copy link
Member Author

k82cn commented May 4, 2019

/assign @TommyLike

@k82cn
Copy link
Member Author

k82cn commented May 4, 2019

xref kubernetes-retired/kube-batch#663

This was referenced May 5, 2019
Closed
Merged
@TommyLike
Copy link
Contributor

@k82cn is there anything still need to be done?

@k82cn
Copy link
Member Author

k82cn commented May 8, 2019

nop, that's ok to close that.

@k82cn k82cn closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TommyLike TommyLike

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
3 participants
@TommyLike @k82cn @volcano-sh-bot