[question] Why not update task role's min member to its replicas, but set it to its replicas in creating podgroup?

[lowang-bh]

I am not sure this is as design or a issue. Can somebody help me to undestand it?

when create new podgroup, if task.MinAvailable == nil, then minTaskMember[task.Name] = task.Replica

volcano/pkg/controllers/job/job_controller_actions.go

Line 667 in 31b47aa

minTaskMember[task.Name] = task.Replicas

minTaskMember := map[string]int32{}
for _, task := range job.Spec.Tasks {
      if task.MinAvailable != nil {
	      minTaskMember[task.Name] = *task.MinAvailable
      } else {
	      minTaskMember[task.Name] = task.Replicas
      }
}

But when updating job, it skip to set role's min member when task.MinAvailable == nil

volcano/pkg/controllers/job/job_controller_actions.go

Line 721 in 31b47aa

if task.MinAvailable == nil {

	if pg.Spec.MinTaskMember == nil {
		pgShouldUpdate = true
		pg.Spec.MinTaskMember = make(map[string]int32)
	}

	for _, task := range job.Spec.Tasks {
		if task.MinAvailable == nil {
			continue
		}
...
	}

What would you like to be added:

	for _, task := range job.Spec.Tasks {
		cnt := task.Replicas
		if task.MinAvailable != nil {
			cnt = *task.MinAvailable
		} 

		if taskMember, ok := pg.Spec.MinTaskMember[task.Name]; !ok {
			pgShouldUpdate = true
			pg.Spec.MinTaskMember[task.Name] = cnt
		} else {
			if taskMember == cnt{
				continue
			}

			pgShouldUpdate = true
			pg.Spec.MinTaskMember[task.Name] = cnt
		}
	}

Why is this needed:

[wangyang0616]

I understand your modification is correct.

[lowang-bh]

/assign