Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make env plugin work in the initContainers? #453

Closed
chenyangxueHDU opened this issue Sep 17, 2019 · 6 comments · Fixed by #613
Closed

Can we make env plugin work in the initContainers? #453

chenyangxueHDU opened this issue Sep 17, 2019 · 6 comments · Fixed by #613
Assignees
Labels
area/controllers kind/bug Categorizes issue or PR as related to a bug.

Comments

@chenyangxueHDU
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind feature

What happened:
when i use env plugin, there is no VK_TASK_INDEX env in the initContainers.
What you expected to happen:
initContainers also have VK_TASK_INDEX env
How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Volcano Version:v0.1
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k82cn
Copy link
Member

k82cn commented Sep 17, 2019

/kind bug

Yes, we should also support that :)

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 17, 2019
@k82cn
Copy link
Member

k82cn commented Sep 17, 2019

/area controllers

@hzxuzhonghu
Copy link
Collaborator

@chenyangxueHDU Why do u need this in initcontainer?

@hzxuzhonghu
Copy link
Collaborator

/assign

@chenyangxueHDU
Copy link
Contributor Author

@chenyangxueHDU Why do u need this in initcontainer?

before the job container running, i will mkdir on the glusterfs in the initContainers, and only one pod will do this.

@hzxuzhonghu
Copy link
Collaborator

There is no difference for you to mkdir in initcontainer or in normal container, assume you have 2 pods per task, each pod share the same pod template. In other word, you will have 2 init containers too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controllers kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants