Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dropdown styles #340

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix dropdown styles #340

merged 1 commit into from
Feb 11, 2025

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jan 26, 2025

resolve #339

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2025
Copy link
Member Author

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before #339
after
1

Signed-off-by: Arhell <arhell333@gmail.com>
@JesseStutler
Copy link
Member

Great! cc @Monokaix @william-wang @kevin-wangzefeng

Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@kevin-wangzefeng kevin-wangzefeng removed the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@volcano-sh-bot volcano-sh-bot merged commit 707a1be into volcano-sh:master Feb 11, 2025
7 checks passed
@kevin-wangzefeng kevin-wangzefeng added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@Arhell Arhell deleted the fix-drop branch February 11, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropdown bug
4 participants