-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate pin
into install
#41
Comments
In general I like the basic proposal, although I do think there is some utility in the distinct operations of pinning a version and fetching a version—even if you often do both together. ("Install" has for this reason always seemed a somewhat murky term to me, and I actually quite like One possibility that occurred to me on rereading this tonight: we could make it so that you always needed |
At least in the discussions we had, there wasn't any talk of removing the I'm on the fence about always requiring the |
From offline discussions: A large majority of the time when a user runs
volta install
while in a package, what they actually meant to do wasvolta pin
. Additionally, it's confusing to runvolta install node@10
, see a success message saying thatnode@10.13.0
was installed and made the default, and then runnode -v
and not see any change because you are in a project that was pinned (see volta-cli/volta#609).We discussed consolidating
volta pin
intovolta install
, so that thevolta install
command is also context-aware, and will do the expected thing depending on whether you are in a project or not. We could also consider having a--default
or other flag, that allows a user to explicitly change the default, even if they are inside a node project.The text was updated successfully, but these errors were encountered: