Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue #46

Open
vorburger opened this issue Nov 15, 2020 · 2 comments
Open

Performance issue #46

vorburger opened this issue Nov 15, 2020 · 2 comments

Comments

@vorburger
Copy link
Owner

The wait(100) in ch.vorburger.exec.ManagedProcess.startExecute() isn't great.

Wouldn't some sort of yield() (:question:) suffice?

@vorburger
Copy link
Owner Author

@mosesn if you have any great idea how we could avoid this, go for (PR) it! I'm not entirely sure if #126 (alone) makes this unnecessary, now.

@mosesn
Copy link
Contributor

mosesn commented Jul 10, 2024

Just to confirm, all we want to do is wait for asyncResult to complete for up to 100ms? Reading the logic I'm a bit confused–it seems like the logic is:

  1. wait for 100ms
  2. if the process threw an exception, bail out
  3. however, if the process started successfully OR if the process has not yet started, set the watchdog value

Do we want to preserve that behavior? or would we want to change it so that it bails out if it hasn't started within 100ms? Regardless, yes, this should be pretty easy to optimize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants