test: switch back to babel-based coverage

c8/v8 coverage is buggy post v20.9.0: nodejs/node#51251

.node-version

@@ -1 +1 @@
-20.14.0
+20.16.0

apps/admin/backend/jest.config.js

@@ -22,7 +22,7 @@ module.exports = {
       lines: 100,
     },
   },
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
   collectCoverageFrom: [
     '**/*.{ts,tsx}',
     '!**/*.d.ts',

apps/admin/backend/src/adjudication.ts

@@ -29,7 +29,7 @@ export function adjudicateVote(
 
   const scannedIsVote = contestVotes
     ? contestVotes.includes(voteAdjudication.optionId)
-    : /* c8 ignore next 1 */
+    : /* istanbul ignore next */
       false;
 
   // if the vote is already the target status, do nothing

apps/admin/backend/src/app.ts

@@ -138,7 +138,7 @@ function getCurrentElectionRecord(
   workspace: Workspace
 ): Optional<ElectionRecord> {
   const electionId = workspace.store.getCurrentElectionId();
-  /* c8 ignore next 3 */
+  /* istanbul ignore next */
   if (!electionId) {
     return undefined;
   }

apps/admin/backend/src/exports/csv_ballot_count_report.ts

@@ -68,7 +68,7 @@ function buildRow({
   const values: string[] = [...metadataValues];
 
   const counts: number[] = [];
-  /* c8 ignore next - trivial fallthrough case */
+  /* istanbul ignore next - trivial fallthrough case */
   const manual = cardCounts.manual ?? 0;
   const { bmd } = cardCounts;
   const total = getBallotCount(cardCounts);
@@ -81,7 +81,7 @@ function buildRow({
 
   if (maxSheetsPerBallot) {
     for (let i = 0; i < maxSheetsPerBallot; i += 1) {
-      /* c8 ignore next - trivial fallthrough case */
+      /* istanbul ignore next - trivial fallthrough case */
       const currentSheetCount = cardCounts.hmpb[i] ?? 0;
       counts.push(currentSheetCount);
     }

apps/admin/backend/src/reports/titles.ts

@@ -148,7 +148,7 @@ export function generateTitleForReport({
           return ok(`Undervoted ${reportType} Report`);
         case 'hasWriteIn':
           return ok(`Write-In ${reportType} Report`);
-        /* c8 ignore next 2 */
+        /* istanbul ignore next */
         default:
           throwIllegalValue(adjudicationFlag);
       }

apps/admin/backend/src/store.ts

@@ -1353,7 +1353,7 @@ export class Store {
 
     for (const adjudication of adjudications) {
       const currentContestVotes =
-        votes[adjudication.contestId] ?? /* c8 ignore next 1 */ [];
+        votes[adjudication.contestId] ?? /* istanbul ignore next */ [];
       if (adjudication.isVote) {
         votes[adjudication.contestId] = [
           ...currentContestVotes,
@@ -1521,7 +1521,7 @@ export class Store {
         ballotStyleId: groupBy.groupByBallotStyle
           ? row.ballotStyleId
           : undefined,
-        /* c8 ignore next - edge case coverage needed for bad party grouping in general election */
+        /* istanbul ignore next - edge case coverage needed for bad party grouping in general election */
         partyId: groupBy.groupByParty ? row.partyId ?? undefined : undefined,
         batchId: groupBy.groupByBatch ? row.batchId : undefined,
         scannerId: groupBy.groupByScanner ? row.scannerId : undefined,
@@ -1880,7 +1880,7 @@ export class Store {
         ballotStyleId: groupBy.groupByBallotStyle
           ? row.ballotStyleId
           : undefined,
-        /* c8 ignore next - edge case coverage needed for bad party grouping in general election */
+        /* istanbul ignore next - edge case coverage needed for bad party grouping in general election */
         partyId: groupBy.groupByParty ? row.partyId ?? undefined : undefined,
         batchId: groupBy.groupByBatch ? row.batchId : undefined,
         scannerId: groupBy.groupByScanner ? row.scannerId : undefined,

apps/admin/backend/src/tabulation/card_counts.ts

@@ -33,7 +33,7 @@ function addCardTallyToCardCounts({
   } else {
     // eslint-disable-next-line no-param-reassign
     cardCounts.hmpb[card.sheetNumber - 1] =
-      /* c8 ignore next - trivial fallback case */
+      /* istanbul ignore next - trivial fallback case */
       (cardCounts.hmpb[card.sheetNumber - 1] ?? 0) + tally;
   }
 

apps/admin/backend/src/tabulation/full_results.ts

@@ -180,7 +180,7 @@ export async function tabulateElectionResults({
           });
         }
       );
-      /* c8 ignore next 3 - debug only */
+      /* istanbul ignore next - debug only */
     } else {
       debug('filter or group by is not compatible with manual results');
     }

apps/admin/backend/src/tabulation/write_ins.ts

@@ -146,7 +146,7 @@ function addWriteInTallyToElectionWriteInSummary({
           isWriteIn: true,
         };
         break;
-      /* c8 ignore next 2 */
+      /* istanbul ignore next */
       default:
         throwIllegalValue(writeInTally);
     }

apps/admin/backend/src/util/auth.ts

@@ -29,7 +29,7 @@ export function constructAuthMachineState(
     return record;
   })();
 
-  /* c8 ignore next 3 - covered by integration testing */
+  /* istanbul ignore next - covered by integration testing */
   const jurisdiction = isIntegrationTest()
     ? TEST_JURISDICTION
     : process.env.VX_MACHINE_JURISDICTION ?? DEV_JURISDICTION;
@@ -64,6 +64,6 @@ export async function getUserRole(
   if (authStatus.status === 'logged_in') {
     return authStatus.user.role;
   }
-  /* c8 ignore next 2 - trivial fallback case */
+  /* istanbul ignore next - trivial fallback case */
   return 'unknown';
 }

apps/admin/backend/src/util/cdf_results.ts

@@ -59,7 +59,7 @@ function buildOfficialCandidates(
   return candidates.map((candidate) => ({
     '@type': 'ElectionResults.Candidate',
     '@id': candidate.id,
-    /* c8 ignore next 1 -- trivial fallthrough case */
+    /* istanbul ignore next -- trivial fallthrough case */
     PartyId: candidate.partyIds?.[0],
     BallotName: asInternationalizedText(candidate.name),
   }));

apps/admin/backend/src/util/write_ins.ts

@@ -40,7 +40,7 @@ export async function getWriteInImageView({
   const contestLayout = layout.contests.find(
     (contest) => contest.contestId === contestId
   );
-  /* c8 ignore next 3 - TODO: revisit our layout assumptions based on our new ballots */
+  /* istanbul ignore next - TODO: revisit our layout assumptions based on our new ballots */
   if (!contestLayout) {
     throw new Error('unable to find a layout for the specified contest');
   }
@@ -52,13 +52,13 @@ export async function getWriteInImageView({
   const writeInOptionIndex = safeParseNumber(
     optionId.slice('write-in-'.length)
   );
-  /* c8 ignore next 3 - TODO: revisit our layout assumptions based on our new ballots */
+  /* istanbul ignore next - TODO: revisit our layout assumptions based on our new ballots */
   if (writeInOptionIndex.isErr() || writeInOptions === undefined) {
     throw new Error('unable to interpret layout write-in options');
   }
 
   const writeInLayout = writeInOptions[writeInOptionIndex.ok()];
-  /* c8 ignore next 3 - TODO: revisit our layout assumptions based on our new ballots */
+  /* istanbul ignore next - TODO: revisit our layout assumptions based on our new ballots */
   if (writeInLayout === undefined) {
     throw new Error('unexpected write-in option index');
   }

apps/admin/backend/src/util/zip.ts

@@ -11,7 +11,7 @@ export function addFileToZipStream(
 ): Promise<void> {
   return new Promise<void>((resolve, reject) => {
     zipStream.entry(file.contents, { name: file.path }, (error) => {
-      /* c8 ignore next 2 - trivial error case */
+      /* istanbul ignore next - trivial error case */
       if (error) {
         reject(error);
       } else {

apps/central-scan/backend/jest.config.js

@@ -12,7 +12,7 @@ module.exports = {
   roots: ['<rootDir>/src'],
   setupFiles: ['<rootDir>/test/set_env_vars.ts'],
   setupFilesAfterEnv: ['<rootDir>/test/setup_custom_matchers.ts'],
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
   collectCoverageFrom: [
     '**/*.{ts,tsx}',
     '!**/node_modules/**',

apps/scan/backend/jest.config.js

@@ -12,7 +12,7 @@ module.exports = {
   roots: ['<rootDir>/src'],
   setupFiles: ['<rootDir>/test/set_env_vars.ts'],
   setupFilesAfterEnv: ['<rootDir>/test/setup_custom_matchers.ts'],
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
   collectCoverageFrom: [
     '**/*.{ts,tsx}',
     '!**/node_modules/**',
@@ -24,8 +24,8 @@ module.exports = {
   coverageThreshold: {
     global: {
       statements: -180,
-      branches: -47,
-      functions: -15,
+      branches: -60,
+      functions: -16,
       lines: -180,
     },
   },

apps/scan/backend/src/scanners/custom/state_machine.ts

@@ -1334,7 +1334,7 @@ export function createPrecinctScannerStateMachine({
               type: interpretation.type,
               reasons: interpretation.reasons,
             };
-          /* c8 ignore next 2 */
+          /* istanbul ignore next */
           default:
             throwIllegalValue(interpretation, 'type');
         }

apps/scan/backend/src/scanners/pdi/state_machine.ts

@@ -1002,7 +1002,7 @@ function setupLogging(
       );
     })
     .onChange(async (context, previousContext) => {
-      /* c8 ignore next */
+      /* istanbul ignore next */
       if (!previousContext) return;
       const changed = Object.entries(context).filter(
         ([key, value]) => previousContext[key as keyof Context] !== value
@@ -1129,7 +1129,7 @@ export function createPrecinctScannerStateMachine({
             return 'calibrating_double_feed_detection.done';
           case state.matches('shoeshineModeRescanningBallot'):
             return 'accepted';
-          /* c8 ignore next 2 */
+          /* istanbul ignore next */
           default:
             throw new Error(`Unexpected state: ${state.value}`);
         }
@@ -1153,7 +1153,7 @@ export function createPrecinctScannerStateMachine({
               type: interpretation.type,
               reasons: interpretation.reasons,
             };
-          /* c8 ignore next 2 */
+          /* istanbul ignore next */
           default:
             return throwIllegalValue(interpretation, 'type');
         }

libs/backend/src/election_package/election_package_io.test.ts

@@ -334,7 +334,7 @@ test('readElectionPackageFromFile errors when given an invalid election', async
   expect(await readElectionPackageFromFile(file)).toEqual(
     err({
       type: 'invalid-election',
-      message: 'Unexpected token o in JSON at position 1',
+      message: `Unexpected token 'o', "not a valid election" is not valid JSON`,
     })
   );
 });
@@ -351,7 +351,7 @@ test('readElectionPackageFromFile errors when given invalid system settings', as
   expect(await readElectionPackageFromFile(file)).toEqual(
     err({
       type: 'invalid-system-settings',
-      message: 'Unexpected token o in JSON at position 1',
+      message: `Unexpected token 'o', "not a valid"... is not valid JSON`,
     })
   );
 });
@@ -368,7 +368,7 @@ test('readElectionPackageFromFile errors when given invalid metadata', async ()
   expect(await readElectionPackageFromFile(file)).toEqual(
     err({
       type: 'invalid-metadata',
-      message: 'Unexpected token a in JSON at position 0',
+      message: `Unexpected token 'a', "asdf" is not valid JSON`,
     })
   );
 });

libs/custom-scanner/jest.config.js

@@ -12,5 +12,5 @@ module.exports = {
     '!src/mocks/**/*.ts',
     '!src/types/**/*.ts',
   ],
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
 };

libs/custom-scanner/src/custom_a4_scanner.ts

@@ -273,9 +273,9 @@ export class CustomA4Scanner implements CustomScanner {
   scan(
     scanParameters: ScanParameters,
     {
-      /* c8 ignore next */
+      /* istanbul ignore next */
       maxTimeoutNoMoveNoScan = 5_000,
-      /* c8 ignore next */
+      /* istanbul ignore next */
       maxRetries = 3,
     }: { maxTimeoutNoMoveNoScan?: number; maxRetries?: number } = {}
   ): Promise<Result<SheetOf<ImageFromScanner>, ErrorCode>> {

libs/custom-scanner/src/parameters.ts

@@ -52,7 +52,7 @@ function convertToMultiSheetDetectionSensorLevelInternal(
       return MultiSheetDetectionSensorLevelInternal.Level3;
     case DoubleSheetDetectOpt.Level4:
       return MultiSheetDetectionSensorLevelInternal.Level4;
-    /* c8 ignore next 2 */
+    /* istanbul ignore next */
     default:
       throwIllegalValue(option);
   }

libs/custom-scanner/src/protocol.ts

@@ -667,7 +667,7 @@ class GetImageDataRequestScanSideCoder extends BaseCoder<ScanSide> {
         case GetImageDataRequestScanSideCoder.SideB:
           return { value: ScanSide.B, bitOffset: decoded.bitOffset };
 
-        /* c8 ignore next 2 */
+        /* istanbul ignore next */
         default:
           return err('InvalidValue');
       }
@@ -819,7 +819,7 @@ export function checkAnswer(data: Buffer): CheckAnswerResult {
       case ResponseErrorCode.INVALID_JOB_ID:
         return { type: 'error', errorCode: ErrorCode.JobNotValid };
 
-      /* c8 ignore next 2 */
+      /* istanbul ignore next */
       default:
         throwIllegalValue(errorCode);
     }
@@ -856,7 +856,7 @@ function mapCoderError<T>(result: Result<T, CoderError>): Result<T, ErrorCode> {
     case 'UnsupportedOffset':
       throw new Error(`BUG: unsupported offset`);
 
-    /* c8 ignore next 2 */
+    /* istanbul ignore next */
     default:
       throwIllegalValue(coderError);
   }

libs/pdi-scanner/jest.config.js

@@ -10,5 +10,5 @@ module.exports = {
     '!src/ts/index.ts',
     '!src/ts/demo.ts',
   ],
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
 };

libs/pdi-scanner/src/ts/scanner_client.ts

@@ -290,7 +290,7 @@ export function createPdiScannerClient() {
   });
 
   pdictl.stderr.on('data', (data) => {
-    /* c8 ignore next */
+    /* istanbul ignore next */
     debug('pdictl stderr:', data.toString('utf-8'));
   });
 

libs/ui/src/reports/precinct_scanner_tally_reports.tsx

@@ -8,7 +8,7 @@ import {
 } from '@votingworks/types';
 import {
   combineElectionResults,
-  getContestsForPrecinct,
+  getContestsForPrecinctSelection,
   getEmptyElectionResults,
 } from '@votingworks/utils';
 import { PrecinctScannerTallyReport } from './precinct_scanner_tally_report';
@@ -50,11 +50,9 @@ export function PrecinctScannerTallyReports({
   });
   const partyIds =
     getPartyIdsForPrecinctScannerTallyReports(electionDefinition);
-  const allContests = getContestsForPrecinct(
+  const allContests = getContestsForPrecinctSelection(
     electionDefinition,
-    precinctSelection.kind === 'SinglePrecinct'
-      ? precinctSelection.precinctId
-      : undefined
+    precinctSelection
   );
 
   return partyIds.map((partyId) => {

libs/utils/jest.config.js

@@ -7,11 +7,11 @@ module.exports = {
   ...shared,
   testEnvironment: 'jsdom',
   setupFilesAfterEnv: ['<rootDir>/src/setupTests.ts'],
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
   coverageThreshold: {
     global: {
-      branches: -30,
-      lines: -123,
+      branches: -35,
+      lines: -124,
     },
   },
   collectCoverageFrom: [