Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factsets for FreeBSD 13 have a blank hostname #215

Closed
msalway opened this issue Nov 24, 2021 · 2 comments · Fixed by #216
Closed

Factsets for FreeBSD 13 have a blank hostname #215

msalway opened this issue Nov 24, 2021 · 2 comments · Fixed by #216

Comments

@msalway
Copy link
Contributor

msalway commented Nov 24, 2021

It looks like when the factsets were regenerated under #210 there have been some unintentional changes to hostname related facts for the FreeBSD 13 factsets that were regenerated.

hostname is now empty string
fqdn has been removed entirely
domain has become "divms.uiowa.edu"

This has happened to both the legacy top-level facts and those nested within the networking tree.

As a result spec tests which expect the host to be named "foo.example.com" or even just a valid domain name are now failing.

@bastelfreak
Copy link
Member

Hi, thanks for raising the issue. Are you ablento provide a PR with fixed factsets?

@alexjfisher
Copy link
Member

Even manually fixing up the broken sets (instead of trying to regenerate everything) would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants