Bug in handling ports in sshd_config when reducing the number of ports that are active

[trevor-vaughan]

Starting scenario

Code

puppet apply -e 'sshd_config { "Port": value => [22,2222,22222,2223] }'

Expectation

Port 22
Port 2222
Port 22222
Port 2223

Reality ✔️

Port 22
Port 2222
Port 22222
Port 2223

Reduce by two entries

Code

puppet apply -e 'sshd_config { "Port": value => [22,2222] }'

Expectation

Port 22
Port 2222

Reality ❌

Port 22
Port 2222
Port 2223

Run Puppet again

Code

puppet apply -e 'sshd_config { "Port": value => [22,2222] }'

Expectation

Port 22
Port 2222

Reality ✔️

Port 22
Port 2222

[raphink]

https://github.com/hercules-team/augeasproviders_ssh/blob/master/lib/puppet/provider/sshd_config/augeas.rb#L73-L83 is supposed to take care of that

[trevor-vaughan]

@raphink Well, I have bad news then :-D