Saving a report doesn't work when passing two catalogs into the CLI

[natemccurdy]

When using the --output_report flag and passing in two catalogs, a report doesn't get saved.

For example, this does not write a report.json:

puppet catalog diff catalog-a.json catalog-b.json --output_report=report.json

Looks like the problem is that the code responsible for writing a report only exists in the conditional branch for retrieving a catalog remotely:
https://github.com/camptocamp/puppet-catalog-diff/blob/v2.3.0/lib/puppet/face/catalog/diff.rb#L182-L187

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[natemccurdy]

Just chiming in to the stale bot doesn't eat this issue. This is still a problem.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[natemccurdy]

<insert activity here>

[raphink]

Hehe, don't mind the bot, he's not that much of a bad boy (though it could be controlled with some kind of ignore label) 😁

[raphink]

Ah, there was an issue open to implement it in the bot probot/stale#110

But the bot closed it 🤣

[natemccurdy]

Rather than continuing this fight with a bot, I decided to just fix the problem myself :)
Here's a proposed fix: #50

[raphink]

This bit is actually useful 😃