grafana_datasource provider with_credentials() returns is_default value

[lnemsick-simp]

https://github.com/voxpupuli/puppet-grafana/blob/master/lib/puppet/provider/grafana_datasource/grafana.rb#L191 returns datasource[:is_default] instead of datasource[:with_credentials]

• Puppet: 4.10.10
• Ruby: 2.1.9
• Distribution: foss
• Module version: v4.1.0

How to reproduce (e.g Puppet code you use)

manifest with the following
grafana_datasource { 'elasticsearch':
ensure => present,
grafana_url => 'https://#{grafana_fqdn}:#{grafana_port}',
grafana_user => 'admin',
grafana_password => 'admin',
type => 'elasticsearch',
url => 'https://#{elasticsearch_fqdn}:9200',
access_mode => 'proxy',
database => '[logstash-]YYYY.MM.DD',
is_default => true,
json_data => {
esVersion => 5,
timeField => '@timestamp',
interval => 'Daily',
tlsSkipVerify => true,
},
require => Class['::grafana::service'],
}

What are you seeing

Puppet manifests with grafana_datasource for which is_default and with_credentials are different, are not idempotent

What behaviour did you expect instead

The manifest should have been idempotent, instead of 'fixing' itself every run.

Output log

Notice: Compiled catalog for grafana.test.local in environment production in 0.60 seconds
Info: Applying configuration version '1518719849'
Notice: /Stage[main]/Main/Grafana_datasource[elasticsearch]/with_credentials: with_credentials changed 'true' to 'false'

Any additional information you'd like to impart

[bastelfreak]

@lnemsick-simp I merged the related issue and a release is currently prepared. I'm going to close this issue. Please reopen if the new release doesnt fix your issue.