Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load modules config only for modules managed by puppet (#90) #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Load modules config only for modules managed by puppet (#90) #91

wants to merge 1 commit into from
+57 −35

Conversation

deric
Copy link

@deric deric commented Aug 3, 2022

Pull Request (PR) description

Avoid exporting all loaded kernel modules as facts.

Only loaded modules will be exported (970 lines -> 16 lines)

$ facter -y --puppet kmods
kmods:
  br_netfilter:
    parameters: {}
    used_by: []
  overlay:
    parameters:
      check_copy_up: "N"
      index: "N"
      metacopy: "N"
      nfs_export: "N"
      permit_mounts_in_userns: "N"
      redirect_always_follow: "Y"
      redirect_dir: "N"
      redirect_max: '256'
      xino_auto: "N"
    used_by: []

Too many facts might overload puppetserver or slow down puppet runs.

This Pull Request (PR) fixes the following issues

Fixes #90

@fraenki
Copy link
Member

fraenki commented Jan 3, 2024

@deric, would you please rebase? It has merge conflicts now. Would love to see this getting merged rather sooner than later. :)

@deric
Copy link
Author

deric commented Jan 3, 2024

@fraenki Yeah, sure. This is a bit old, I don't recall the details.

@deric
Copy link
Author

deric commented Jan 3, 2024

@fraenki Rebased, please test this. It might be breaking change for some setups.

@deric
Copy link
Author

deric commented Feb 16, 2024

@fraenki Rebased

@jordyb6
Copy link

jordyb6 commented Nov 20, 2024

What's the status on this? Can this get merged?

@yakatz
Copy link

yakatz commented Nov 20, 2024

What is the chance there is anyone relying on this fact the way it currently works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make facts export optional
4 participants
@deric @fraenki @jordyb6 @yakatz