Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reverse this check #17

Closed
baurmatt opened this issue Jan 14, 2019 · 5 comments
Closed

Add option to reverse this check #17

baurmatt opened this issue Jan 14, 2019 · 5 comments

Comments

@baurmatt
Copy link
Contributor

From README.md

Including a class by a relative name might lead to unexpected results in Puppet 3. This plugin is not recommended for use with Puppet code that has dropped support for Puppet 3 (EOL 20161231).

I'd like to see an option to reverse this check meaning a warning if :: is present but I'm not even sure if it is possible to configure a Puppet-Lint plugin.

The basic implementation is already done here -> https://github.com/syseleven/puppet-lint-absolute_classname-check/tree/feature/reverse

@bastelfreak
Copy link
Member

oh yes, a reverse check would be awesome <3

@baurmatt
Copy link
Contributor Author

Are you aware of a way to configure a puppet-lint plugin or do we have to maintain another repository/plugin? :(

baurmatt added a commit to syseleven/puppet-lint-absolute_classname-check that referenced this issue Feb 6, 2019
Meaning: Warn if there are :: in front of a class definition.

Fixes voxpupuli#17.
@baurmatt
Copy link
Contributor Author

baurmatt commented Feb 8, 2019

@alexjfisher Sounds good, but I think we should first release that change to Rubygems ;) Can you do that? I'm happy to do the change in modulesync_config once this is done.

@alexjfisher
Copy link
Member

Totally forgot about actually needing a release! Looks like travis is setup correctly. Just need a release PR to bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants