Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ubuntu 18.04? #1307

Closed
thaiphv opened this issue Jan 30, 2019 · 7 comments · Fixed by #1319
Closed

Support for Ubuntu 18.04? #1307

thaiphv opened this issue Jan 30, 2019 · 7 comments · Fixed by #1319

Comments

@thaiphv
Copy link

thaiphv commented Jan 30, 2019

Do we have plan to support Ubuntu 18.04?

@danhart
Copy link

danhart commented Jan 30, 2019

This would be great for us as well 👍

@morremeyer
Copy link
Contributor

I use the module on Ubuntu 18.04 without problems. It is just not yet added to the metadata so far - maybe there are some integration problems I’ve not seen yet.

@LongLiveCHIEF
Copy link

There shouldn't be any compatibility issues at all with this module on any Ubuntu 16, 17, or 18 release. As @mauricemeyer said, it's just not in the metadata yet.

In the meantime, if you do run into any issues, go ahead and register an issue as if it was listed as fully supported and we'll take a look at it.

@Dan33l
Copy link
Member

Dan33l commented Mar 5, 2019

I am not user of this module, but if your feedback is that it should mainly work, i prefer to declare the module with ubuntu18.04 as supported OS.

@LongLiveCHIEF are you user of the module on 18.04 ?

@LongLiveCHIEF
Copy link

@Dan33l Yep.

I just thought we were controlling supported OS's in modulesync_config project.

@Dan33l
Copy link
Member

Dan33l commented Mar 5, 2019

The list of files managed by modulesync are listed here:
https://github.com/voxpupuli/modulesync_config/tree/master/moduleroot

The file metadata.json is not present and so not managed.

It should be possible:

  • to add OS as supported by the module by updating metadata.json and so with facterdb extend unit tests automatically .
  • to update travis and so run acceptance on 18.04.

If no one sees reason not to add Ubuntu18.04, i can take care of it.

@Dan33l
Copy link
Member

Dan33l commented Mar 5, 2019

It looks that acceptance tests catch some not expected items. And so it can not be just update of medata.json. Details #1319

Any user of the module can have a look in the failing tests ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants