Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx::string_mappings in last tag v6.0.0 #1604

Open
flepoutre opened this issue Jun 14, 2024 · 2 comments
Open

nginx::string_mappings in last tag v6.0.0 #1604

flepoutre opened this issue Jun 14, 2024 · 2 comments

Comments

@flepoutre
Copy link

flepoutre commented Jun 14, 2024

Hello,
In the last tag v6.0.0, I have the impression that we are obliged to declare a mappings.

For example I can't use this (hiera example) :

nginx::string_mappings:
  uuid:
    ensure: present
    string: '$host'
    default: "''"
    mappings: {}

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Method call, max(): Wrong number of arguments need at least one

Could we make this possible again ?

Thanks.

@kenyon kenyon changed the title nginx::string_mappings in last tag v6.0.0 nginx::string_mappings in last tag v6.0.0 Jun 15, 2024
@TheMeier TheMeier self-assigned this Jun 18, 2024
@TheMeier
Copy link
Contributor

This is likely because of this change: #1575

This code breaks https://github.com/jay7x/puppet-nginx/blob/master/templates/conf.d/map.epp#L26 if mappings is empty.

I don't know what if the empty hash is a valid use case or not.

@TheMeier TheMeier removed their assignment Jun 20, 2024
@flepoutre
Copy link
Author

Hello, we have a few cases where the hash is empty on prod env ...
It would be nice to make this possible.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants