Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker_connections must be integer since 'Introducing Puppet Module Tool' #472

Closed
stefanandres opened this issue Oct 9, 2014 · 1 comment

Comments

@stefanandres
Copy link

Since 9bd63d34 the nginx module cannot be loaded if you do not pass all default parameters from outside (e.g. hiera) to the nginx class (which before were IN the module) or pass all parameters via class parameters.

If they are non optional parameters, they should not be "undef" but really puppet non optional parameters without fake default values so that proper puppet errors appear when not setting those variables.

puppet apply -e 'include nginx' 
Error: $worker_connections must be an integer. at /opt/puppet-upstream/nginx/manifests/config.pp:87 on node xxx
Error: $worker_connections must be an integer. at /opt/puppet-upstream/nginx/manifests/config.pp:87 on node xxx
@jfryman
Copy link
Contributor

jfryman commented Oct 9, 2014

Yes, that is correct. This is due to https://github.com/jfryman/puppet-nginx/blob/master/docs/hiera.md#installation.

That being said, I am in talks with PuppetLabs about puppet-module-tool in general, and it is highly probably that it'll come back out due to some performance problems associated with it. So, you can either revert to 0.0.10, or update Hiera to load the tool.

@jfryman jfryman closed this as completed Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants