Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding iphash to Upstream has no effect #661

Closed
BnMcG opened this issue Jul 16, 2015 · 2 comments
Closed

Adding iphash to Upstream has no effect #661

BnMcG opened this issue Jul 16, 2015 · 2 comments
Labels
bug Something isn't working

Comments

@BnMcG
Copy link

BnMcG commented Jul 16, 2015

My Puppet config looks as so:

# NGINX config
        class { 'nginx': }

        $upstream_config = {
                'ip_hash'   => '',
                'keepalive' => '20',
        }

        nginx::resource::upstream { 'app_app':
                members => [
                        '10.99.0.10',
                ],
                upstream_cfg_prepend => $upstream_config,
        }

        nginx::resource::vhost { 'app.app.com':
                proxy => 'http://app_app',
                ipv6_enable => true,
        }

When applying my configuration, the "keepalive" value seems to be set in the actual configuration file, but iphash does not:

upstream app_app {


  keepalive 20;

  server     10.99.0.10  fail_timeout=10s;
}

Have I done something wrong? Why isn't ip_hash being enabled? I installed the module today so I guess I have the latest version.

@BnMcG
Copy link
Author

BnMcG commented Jul 16, 2015

After a little playing around, this seems to work if I specify:

'ip_hash'   => ' ',

(Note the extra space between the ''s), but specifying an empty value as I saw in the documentation in the module source code does not work.

@3flex 3flex added the bug Something isn't working label Aug 12, 2015
@wyardley
Copy link
Collaborator

wyardley commented Oct 8, 2016

As mentioned in #563, I tried using '' (via hiera), and it did seem to work. Are you still able to reproduce this issue @BnMcG (with a recent version of the module)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants