Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facter Rspec tests hangs on 2.3.0 #917

Closed
petems opened this issue Oct 11, 2016 · 6 comments
Closed

Facter Rspec tests hangs on 2.3.0 #917

petems opened this issue Oct 11, 2016 · 6 comments
Labels
bug Something isn't working

Comments

@petems
Copy link
Member

petems commented Oct 11, 2016

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: PUPPET_VERSION="~> 4.0"
  • Ruby: 2.3.1
  • Module version: Unsure

What are you seeing

Facter::Util::Fact
  neither nginx or openresty in path
    should eq nil
  nginx
    with current version output format

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

What behaviour did you expect instead

Green build

Output log

Facter::Util::Fact
  neither nginx or openresty in path
    should eq nil
  nginx
    with current version output format

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

Will add debug logs to Travis build to see what the cause is, it passes when run locally on OSX.

@petems petems added the bug Something isn't working label Oct 11, 2016
@bastelfreak
Copy link
Member

Tested it locally, works on my Archlinux box. Ruby:

ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]

Gem versions:

Gems included by the bundle:
  * CFPropertyList (2.2.8)
  * ast (2.3.0)
  * bundler (1.12.5)
  * diff-lcs (1.2.5)
  * domain_name (0.5.20160826)
  * facter (2.4.6)
  * facterdb (0.3.6)
  * hiera (3.2.1)
  * http-cookie (1.0.2)
  * jgrep (1.4.1)
  * json (1.8.3)
  * json_pure (1.8.3)
  * mcollective-client (2.9.0)
  * metaclass (0.0.4)
  * metadata-json-lint (0.0.11)
  * mime-types (2.99.2)
  * mocha (1.1.0)
  * netrc (0.11.0)
  * parser (2.3.1.2)
  * powerpack (0.1.1)
  * puppet (4.6.2)
  * puppet-blacksmith (3.4.0)
  * puppet-lint (2.0.2)
  * puppet-lint-absolute_classname-check (0.2.4)
  * puppet-lint-classes_and_types_beginning_with_digits-check (0.1.2)
  * puppet-lint-leading_zero-check (0.1.1)
  * puppet-lint-trailing_comma-check (0.3.2)
  * puppet-lint-unquoted_string-check (0.3.0)
  * puppet-lint-variable_contains_upcase (1.0.2)
  * puppet-lint-version_comparison-check (0.2.1)
  * puppet-strings (0.4.0)
  * puppet-syntax (2.1.0)
  * puppetlabs_spec_helper (1.2.2)
  * rainbow (2.1.0)
  * rake (11.2.2)
  * rest-client (1.8.0)
  * rspec (3.5.0)
  * rspec-core (3.5.3)
  * rspec-expectations (3.5.0)
  * rspec-mocks (3.5.0)
  * rspec-puppet (2.4.0 85bcc19)
  * rspec-puppet-facts (1.6.1)
  * rspec-puppet-utils (2.2.1)
  * rspec-support (3.5.0)
  * rubocop (0.42.0)
  * rubocop-rspec (1.7.0)
  * ruby-progressbar (1.8.1)
  * spdx-licenses (1.1.0)
  * stomp (1.4.3)
  * systemu (2.6.5)
  * unf (0.1.4)
  * unf_ext (0.0.7.2)
  * unicode-display_width (1.1.0)
  * voxpupuli-release (0.3.0 4fc386d)
  * yard (0.9.5)

@bastelfreak
Copy link
Member

wupsi. I updated my local gems, not it hangs on the same facter test:

Fetching https://github.com/rodjek/rspec-puppet.git
Fetching https://github.com/voxpupuli/voxpupuli-release-gem.git
Fetching gem metadata from https://rubygems.org/
Fetching version metadata from https://rubygems.org/
Fetching dependency metadata from https://rubygems.org/
Resolving dependencies...............................................................................
Installing rake 11.3.0 (was 11.2.2)
Using CFPropertyList 2.2.8
Using ast 2.3.0
Using diff-lcs 1.2.5
Using unf_ext 0.0.7.2
Using facter 2.4.6
Using json 1.8.3
Using hiera 3.2.1
Using json_pure 1.8.3
Using stomp 1.4.3
Using systemu 2.6.5
Using metaclass 0.0.4
Using spdx-licenses 1.1.0
Installing mime-types 2.99.3 (was 2.99.2)
Using netrc 0.11.0
Using powerpack 0.1.1
Using puppet-lint 2.0.2
Using yard 0.9.5
Using rspec-support 3.5.0
Using rainbow 2.1.0
Using rspec-puppet-utils 2.2.1
Using ruby-progressbar 1.8.1
Installing unicode-display_width 1.1.1 (was 1.1.0)
Using bundler 1.12.5
Using puppet-syntax 2.1.0
Installing parser 2.3.1.4 (was 2.3.1.2)
Using unf 0.1.4
Using jgrep 1.4.1
Installing puppet 4.7.0 (was 4.6.2)
Using mcollective-client 2.9.0
Installing mocha 1.2.0 (was 1.1.0)
Using metadata-json-lint 0.0.11
Using puppet-lint-absolute_classname-check 0.2.4
Using puppet-lint-classes_and_types_beginning_with_digits-check 0.1.2
Using puppet-lint-leading_zero-check 0.1.1
Using puppet-lint-trailing_comma-check 0.3.2
Using puppet-lint-unquoted_string-check 0.3.0
Using puppet-lint-variable_contains_upcase 1.0.2
Using puppet-lint-version_comparison-check 0.2.1
Installing rspec-core 3.5.4 (was 3.5.3)
Using rspec-expectations 3.5.0
Using rspec-mocks 3.5.0
Installing rubocop 0.43.0 (was 0.42.0)
Using domain_name 0.5.20160826
Installing facterdb 0.3.7 (was 0.3.6)
Using puppet-strings 0.4.0
Using rspec 3.5.0
Using rubocop-rspec 1.7.0
Installing http-cookie 1.0.3 (was 1.0.2)
Installing rspec-puppet-facts 1.7.0 (was 1.6.1)
Using rspec-puppet 2.4.0 from https://github.com/rodjek/rspec-puppet.git (at master@8e49f19)
Using rest-client 1.8.0
Using puppetlabs_spec_helper 1.2.2
Using puppet-blacksmith 3.4.0
Using voxpupuli-release 0.3.0 from https://github.com/voxpupuli/voxpupuli-release-gem.git (at master@4fc386d)
Bundle updated!
Gems in the groups system_tests and development were not installed.

@petems
Copy link
Member Author

petems commented Oct 11, 2016

Yep, confirmed it's an issue with one of those gems updating.

With the following added to the gemfile, the tests dont hang on 2.3.1 anymore:

gem 'rake' , '11.2.2'
  gem 'mime-types' , '2.99.2'
  gem 'unicode-display_width','1.1.0'
  gem 'parser', '2.3.1.2'
  gem 'mocha', '1.1.0'
  gem 'rspec-core', '3.5.3'
  gem 'rubocop' , '0.42.0'
  gem 'facterdb', '0.3.6'
  gem 'http-cookie', '1.0.2'
  gem 'rspec-puppet-facts', '1.6.1'

@wyardley
Copy link
Collaborator

Thanks for figuring this out!

@petems
Copy link
Member Author

petems commented Oct 12, 2016

See freerange/mocha#272 for more background 👍

@wyardley
Copy link
Collaborator

Now resolved in a merged PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants