dont set ACLs if there are no ACLs to change #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
tests
branch
3 times, most recently
from
18014ce to
594b555
Compare
ekohl
reviewed
Jan 24, 2022
|
|
||
| require 'spec_helper_acceptance' | ||
|
|
||
| describe 'posix_acl' do |
There was a problem hiding this comment.
This now overlaps with the other test. I don't know if that works well.
There was a problem hiding this comment.
ah. I can move it to the existing file.
There was a problem hiding this comment.
The alternative is to use a new name, but either works.
bastelfreak
force-pushed
the
tests
branch
2 times, most recently
from
e736d07 to
9e1b400
Compare
|
I will try to debug this tomorrow. a customer reported it. This bug is already present in our 1.1.0 release. |
bastelfreak
force-pushed
the
tests
branch
2 times, most recently
from
8b13cc7 to
01a2030
Compare
|
I'm pretty sure this is a valid bugfix and won't introduce a regression, but not 100% sure :D |
bastelfreak
changed the title
|
I would like to rebase it after #111 got merged |
smortex
reviewed
Jan 25, 2022
|
Fixes #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues