Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to selmodule/selboolean for selinux::module/boolean? #70

Closed
jyaworski opened this issue Nov 15, 2015 · 2 comments
Closed

Move to selmodule/selboolean for selinux::module/boolean? #70

jyaworski opened this issue Nov 15, 2015 · 2 comments

Comments

@jyaworski
Copy link
Member

Hello:

It looks like puppet has support for selmodule and selboolean types.

https://docs.puppetlabs.com/references/latest/type.html#selboolean

https://docs.puppetlabs.com/references/latest/type.html#selmodule

Should we modify the existing classes for these to take advantage of the built-in types?

@earsdown
Copy link

-9999 for this idea.

  1. This change is not backward compatible.
  2. You've just broken systems that depend on previous functionality (like selinux::module's use_makefile parameter that disappeared without warning).
  3. If we wanted to use native types, we would be using one of the other selinux modules (there are many). Instead, we're using this module because we find it's better than using the native types. Which I thought was rather obvious.

If you really want to do this, consider publishing it under a different module name. If you can't revert this change and restore previous behavior, please consider putting a gigantic notice in the README warning users not to depend on this module for anything remotely important.

@jyaworski
Copy link
Member Author

Hello:

This was solved in #73. Native types only install the compiled .pp files for selmodule.

Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants