Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show diffs by default #21

Open
TheMeier opened this issue Oct 8, 2024 · 3 comments
Open

Don't show diffs by default #21

TheMeier opened this issue Oct 8, 2024 · 3 comments

Comments

@TheMeier
Copy link
Contributor

TheMeier commented Oct 8, 2024

file resources in this module should set show-diff to false by default, since there is a high likelihood that files rendered by this module contain secrets

@ekohl
Copy link
Member

ekohl commented Oct 8, 2024

Would it make sense to use Sensitive where possible? That way it automatically gets redacted if needed.

@TheMeier
Copy link
Contributor Author

TheMeier commented Oct 8, 2024

Given the very generic template, I don't immediately see how one would do that.

@ekohl
Copy link
Member

ekohl commented Oct 11, 2024

EPP has special handling for Sensitive so if a users pass in any Sensitive instead of plain String I'd expect it to already do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants