versionlock should trigger yum clean all

[TJM]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.5.18
• Ruby: ruby 2.4.9p362 (2019-10-02 revision 67824) [x86_64-linux]
• Distribution: CentOS 7.8
• Module version: 3f35c56

How to reproduce (e.g Puppet code you use)

• Install a specific version of a package with versionlock enabled
• Update version (and versionlock)
• Install fails until you yum clean all

What are you seeing

Error: Could not update: Execution of '/bin/yum -d 0 -e 0 -y install kubelet-1.15.12' returned 1: Error: Nothing to do
Error: /Stage[main]/Kubernetes::Packages/Package[kubelet]/ensure: change from 'purged' to '1.15.12' failed: Could not update: Execution of '/bin/yum -d 0 -e 0 -y install kubelet-1.15.12' returned 1: Error: Nothing to do

What behaviour did you expect instead

Notice: /Stage[main]/Kubernetes::Packages/Package[kubelet]/ensure: created

Output log

(see above)

Any additional information you'd like to impart

I think any change to yum repos or versionlock should trigger a yum clean all (perhaps optionally?)

[psaiz]

I wonder if this could be achieved setting the

yum::plugin::versionlock::clean: true

Looking at https://github.com/voxpupuli/puppet-yum/blob/master/manifests/plugin/versionlock.pp#L7, if the default was 'true' instead of 'false', it looks like we would get the behavior that Tommy suggests.

[TJM]

oh yea. Why would it default to false? (shrug) Thanks for the pointer.