Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: The kp_norm function should live in matrix_props #245

Closed
vprusso opened this issue Nov 15, 2023 · 0 comments · Fixed by #246
Closed

Refactor: The kp_norm function should live in matrix_props #245

vprusso opened this issue Nov 15, 2023 · 0 comments · Fixed by #246
Assignees
@purva-thakre
Labels
good first issue Good for newcomers

Comments

@vprusso
Copy link
Owner

vprusso commented Nov 15, 2023

Right now the kp_norm file lives in helper/ but it should live in matrix_props/ where other such norm calculations reside as well.
@vprusso vprusso added the good first issue Good for newcomers label Nov 15, 2023
@purva-thakre purva-thakre self-assigned this Nov 15, 2023
@purva-thakre purva-thakre mentioned this issue Nov 15, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purva-thakre purva-thakre

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pytest Coverage: kp_norm vprusso/toqito
2 participants
@vprusso @purva-thakre